-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multichain token detection #28380
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
7 tasks
salimtb
changed the title
Salim/multichain token detection final
feat: multichain token detection
Nov 8, 2024
salimtb
force-pushed
the
salim/multichain-token-detection-final
branch
from
November 8, 2024 13:34
4583bad
to
1b8fe67
Compare
salimtb
force-pushed
the
salim/multichain-token-detection-final
branch
from
November 8, 2024 14:01
1b8fe67
to
fde2ca2
Compare
Builds ready [fde2ca2]
Page Load Metrics (2038 ± 79 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [e899713]
Page Load Metrics (1965 ± 125 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
closing this PR because the changes has been moved to #28444 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TokenDetectionController is responsible for detecting and keeping an updated list of all tokens across supported chains. This dataset is stored in the detectedTokens state variable within Metamask’s state. After completing this task, token detection will be enhanced by implementing periodic polling across all networks linked to the wallet, resulting in a more comprehensive dataset available to users.
For each network added to the wallet, the polling loop will receive the network as a parameter and execute token autodetection for it. Once results are available, they will be stored in detectedTokensAllChains, organized by chainId. This approach enables us to retrieve a comprehensive list of detected tokens across all networks.
This should now be working to test locally. Here's some steps to run this locally with core PR:
yarn build
"@metamask/assets-controllers": "../core/packages/assets-controllers",
Related issues
Fixes: #3431
Manual testing steps
yarn
PORTFOLIO_VIEW=1 yarn start
Screenshots/Recordings
Before
After
Screen.Recording.2024-11-08.at.14.27.23.mov
Pre-merge author checklist
Pre-merge reviewer checklist