Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove newPendingTransaction event. #1602

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove newPendingTransaction event. #1602

wants to merge 2 commits into from

Conversation

bgravenorst
Copy link
Contributor

Description

Removed the newPendingTransaction event for networks that do not support it.

Issue(s) fixed

Fixes #1600

Preview

Checklist

Complete this checklist before merging your PR:

  • If this PR contains a major change to the documentation content, I have added an entry to the top of the "What's new?" page.
  • The proposed changes have been reviewed and approved by a member of the documentation team.

@bgravenorst bgravenorst requested review from a team as code owners October 4, 2024 04:41
@vercel Vercel
Copy link

vercel bot commented Oct 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metamask-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 5:24am

@socket-security Socket Security
Copy link

socket-security bot commented Oct 4, 2024 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/[email protected]

View full report↗︎

joaniefromtheblock
joaniefromtheblock approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@joaniefromtheblock joaniefromtheblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexandratran
Copy link
Contributor

@bgravenorst can you remove your package-lock.json changes? Dependencies are updated in the latest merged PR, so you can pull in those changes and it won't require an approval from Activation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaniefromtheblock joaniefromtheblock joaniefromtheblock approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove support for newPendingTransactions
3 participants
@bgravenorst @alexandratran @joaniefromtheblock