Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync latest changes from Infura #1581

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Sync latest changes from Infura #1581

merged 2 commits into from
Sep 26, 2024

Conversation

alexandratran
Copy link
Contributor

@alexandratran alexandratran commented Sep 26, 2024 •
edited
Loading

Description

Syncs latest unsynced changes from Infura. Additional edits as needed.

Issue(s) fixed

Fixes #1536
Fixes #1550 – also update some formatting issues, and remove linea from file names for consistency and conciseness
Fixes #1553
Fixes #1554
Fixes #1574
Also duplicates https://github.com/INFURA/docs/pull/305

Preview

https://metamask-docs-e53xl9x7n-metamask-web.vercel.app/services/

Checklist

Complete this checklist before merging your PR:

  • If this PR contains a major change to the documentation content, I have added an entry to the top of the "What's new?" page.
  • The proposed changes have been reviewed and approved by a member of the documentation team.

@alexandratran alexandratran requested a review from a team as a code owner September 26, 2024 22:10
@vercel Vercel
Copy link

vercel bot commented Sep 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metamask-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 11:50pm

bgravenorst
bgravenorst previously approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpicks. Lgtm

docs/whats-new.md Outdated Show resolved Hide resolved
...ces/tutorials/ethereum/use-infura-as-a-reverse-proxy/use-infura-as-a-backup-for-your-node.md Outdated Show resolved Hide resolved
...ces/tutorials/ethereum/use-infura-as-a-reverse-proxy/use-infura-as-a-backup-for-your-node.md Outdated Show resolved Hide resolved
...ces/tutorials/ethereum/use-infura-as-a-reverse-proxy/use-infura-as-a-backup-for-your-node.md Outdated Show resolved Hide resolved
@alexandratran @bgravenorst
Apply suggestions from code review
b3d786e 
Co-authored-by: Byron Gravenorst <[email protected]>
@alexandratran alexandratran merged commit b1b4766 into main Sep 26, 2024
9 checks passed
@alexandratran alexandratran deleted the 1536-sync-infura-updates branch September 26, 2024 23:55
@Japheth2004 Japheth2004 mentioned this pull request Oct 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgravenorst bgravenorst bgravenorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@alexandratran @bgravenorst