feat(mm-login): improve metamask login #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TrofimovAnton85
previously approved these changes
Sep 24, 2024
aednikanov
previously approved these changes
Sep 24, 2024
cedricmagne
dismissed stale reviews from TrofimovAnton85 and aednikanov
via
dbf57b5
TrofimovAnton85
approved these changes
Sep 25, 2024
aednikanov
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improving MetaMask login in any use cases. Even if you only need wallet addresses or need wallet profile ID.
Catching errors silently if you are on wallet references pages and the login flow fails on fetching profile ID