Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflows, fix lint issues, make npm default manager #1563

Merged
merged 44 commits into from
Sep 27, 2024
Merged
Show file tree
Hide file tree
Changes from 42 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
2396618
Propagate sentry keys during build
Sep 19, 2024
0529159
Fix indentation
Sep 19, 2024
44403fb
Fix crowding yml
Sep 19, 2024
7521b4d
Update lock files
Sep 19, 2024
6ba267d
Ignore dependabot in actionslint
Sep 19, 2024
78bfca8
Fix linting issues
Sep 19, 2024
d866daf
Css module refactoring
Sep 19, 2024
5fa8b95
Fix css modules linting
Sep 19, 2024
ad3e539
skip dependabot workflow linting
Sep 19, 2024
3e285c1
skip dependabot workflow linting
Sep 19, 2024
84c2e5a
fiz stylelint config
Sep 19, 2024
36771fb
fix style linting
Sep 19, 2024
0f517f1
fix tsc lint issues
Sep 19, 2024
33dfda4
fix eslint config
Sep 19, 2024
7088740
fix lock files
Sep 19, 2024
e0cec4a
fix lock files, eslint version
Sep 19, 2024
a23a3c1
eslint config fix
Sep 19, 2024
bb21827
eslint config fix
Sep 19, 2024
0b161be
package lock
Sep 20, 2024
a2407a0
package lock
Sep 20, 2024
44647b2
docusaurus theme
Sep 20, 2024
6bacb2f
workflow checks
Sep 20, 2024
4807032
workflow checks
Sep 20, 2024
6fb0d08
md linting
Sep 20, 2024
05469be
Merge conflicts
Sep 24, 2024
3c61774
Fix merge conflicts
Sep 24, 2024
12ccfd2
Fix merge conflicts
Sep 24, 2024
c1287cb
Merge branch 'main' into sentry-keys-on-build
Sep 24, 2024
2c1255e
Fix merge conflicts
Sep 24, 2024
0878cb7
Fix issues
Sep 25, 2024
ae49d36
yarn instead npm
Sep 25, 2024
190a912
yarn instead npm
Sep 25, 2024
1d0447a
yarn instead npm
Sep 25, 2024
5dbfbdc
revert to npm
Sep 25, 2024
e9f127d
Update npn lock
Sep 25, 2024
6d0650d
Make npm default manager
Sep 26, 2024
096871a
move dependabot out of workflows
Sep 26, 2024
b8268a1
fix dependabot config
Sep 26, 2024
d466110
Merge branch 'main' into sentry-keys-on-build
Sep 26, 2024
f77f0d4
fix linting errors
Sep 26, 2024
b0dd290
fix linting errors
Sep 26, 2024
c630640
fix tsc linting errors
Sep 26, 2024
9c2dd33
Merge branch 'main' into sentry-keys-on-build
Sep 27, 2024
563d989
fix tsc linting errors
Sep 27, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .eslintignore

This file was deleted.

20 changes: 0 additions & 20 deletions .eslintrc.js

This file was deleted.

8 changes: 0 additions & 8 deletions .gitattributes

This file was deleted.

2 changes: 0 additions & 2 deletions .github/workflows/dependabot.yml → .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
name: 'Dependency Review'

version: 2
updates:
- package-ecosystem: "npm"
Expand Down
14 changes: 8 additions & 6 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,18 @@ name: Build

on:
workflow_call:
secrets:
SEGMENT_ANALYTICS_KEY:
required: true
LD_CLIENT_ID:
required: true
secrets:
SEGMENT_ANALYTICS_KEY:
required: true
LD_CLIENT_ID:
required: true
SENTRY_KEY:
required: true

env:
SEGMENT_ANALYTICS_KEY: ${{ secrets.SEGMENT_ANALYTICS_KEY }}
LD_CLIENT_ID: ${{ secrets.LD_CLIENT_ID }}

SENTRY_KEY: ${{ secrets.SENTRY_KEY }}

jobs:
build:
Expand Down
14 changes: 8 additions & 6 deletions .github/workflows/case.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,18 @@ name: Check file name case

on:
workflow_call:
secrets:
SEGMENT_ANALYTICS_KEY:
required: true
LD_CLIENT_ID:
required: true
secrets:
SEGMENT_ANALYTICS_KEY:
required: true
LD_CLIENT_ID:
required: true
SENTRY_KEY:
required: true

env:
SEGMENT_ANALYTICS_KEY: ${{ secrets.SEGMENT_ANALYTICS_KEY }}
LD_CLIENT_ID: ${{ secrets.LD_CLIENT_ID }}

SENTRY_KEY: ${{ secrets.SENTRY_KEY }}

jobs:
case:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/crowdin.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Crowdin Action

on:
push:
path: ["i18n/**"]
paths: ["i18n/**"]
branches: [main]

permissions: write-all
Expand Down
16 changes: 9 additions & 7 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,18 @@ name: Check for lint, spelling and link errors

on:
workflow_call:
secrets:
SEGMENT_ANALYTICS_KEY:
required: true
LD_CLIENT_ID:
required: true
secrets:
SEGMENT_ANALYTICS_KEY:
required: true
LD_CLIENT_ID:
required: true
SENTRY_KEY:
required: true

env:
SEGMENT_ANALYTICS_KEY: ${{ secrets.SEGMENT_ANALYTICS_KEY }}
LD_CLIENT_ID: ${{ secrets.LD_CLIENT_ID }}

SENTRY_KEY: ${{ secrets.SENTRY_KEY }}

jobs:
lint:
Expand All @@ -24,7 +26,7 @@ jobs:
- uses: actions/checkout@v4

- name: Lint
uses: ConsenSys/docs-gha/lint@main
uses: ConsenSys/docs-gha/lint@cc8b9d9065f5f20b105954f8e806f55c1e235ecd
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,21 +25,23 @@ jobs:
secrets:
SEGMENT_ANALYTICS_KEY: ${{ secrets.SEGMENT_ANALYTICS_DEV_KEY }}
LD_CLIENT_ID: ${{ secrets.LD_CLIENT_ID }}
SENTRY_KEY: ${{ secrets.SENTRY_KEY }}

lint:
name: Lint
uses: ./.github/workflows/lint.yml
secrets:
SEGMENT_ANALYTICS_KEY: ${{ secrets.SEGMENT_ANALYTICS_DEV_KEY }}
LD_CLIENT_ID: ${{ secrets.LD_CLIENT_ID }}
SENTRY_KEY: ${{ secrets.SENTRY_KEY }}

case:
name: Case
uses: ./.github/workflows/case.yml
secrets:
SEGMENT_ANALYTICS_KEY: ${{ secrets.SEGMENT_ANALYTICS_DEV_KEY }}
LD_CLIENT_ID: ${{ secrets.LD_CLIENT_ID }}

SENTRY_KEY: ${{ secrets.SENTRY_KEY }}

all-jobs-completed:
name: All jobs completed
Expand Down
12 changes: 0 additions & 12 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,6 @@
.cache-loader
.idea

# yarn v3 (w/o zero-install)
# See: https://yarnpkg.com/getting-started/qa#which-files-should-be-gitignored
.pnp.*
.yarn/*
!.yarn/patches
!.yarn/plugins
!.yarn/releases
!.yarn/sdks
!.yarn/versions

# Misc
.DS_Store
.env.local
Expand All @@ -27,8 +17,6 @@
.env.production.local

npm-debug.log*
yarn-debug.log*
yarn-error.log*
.vercel
.envrc
.env
6 changes: 6 additions & 0 deletions .stylelintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"extends": "stylelint-config-standard",
"rules": {
"selector-class-pattern": null
}
}
9 changes: 0 additions & 9 deletions .yarn/plugins/@yarnpkg/plugin-allow-scripts.cjs

This file was deleted.

873 changes: 0 additions & 873 deletions .yarn/releases/yarn-3.4.1.cjs

This file was deleted.

15 changes: 0 additions & 15 deletions .yarnrc.yml

This file was deleted.

4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ To contribute changes:
> `developer-tools` directories.
> - If you add a new documentation page, edit `wallet-sidebar.js`, `snaps-sidebar.js`,
> `services-sidebar.js`, or `dashboard-sidebar.js` to add the page to the
> [sidebar](https://docs-template.consensys.net/contribute/configure-docusaurus#sidebar).
> [sidebar](https://docs-template.consensys.io/create/configure-docusaurus#sidebar).
> - If you delete, rename, or move a documentation file, add a
> [redirect](https://vercel.com/docs/edge-network/redirects#configuration-redirects).
> - See additional instructions for [updating the interactive API reference](#update-the-interactive-api-reference).
Expand Down Expand Up @@ -251,5 +251,5 @@ export SEGMENT_ANALYTICS_KEY="<your key>"
Then build the project in production mode using the following command:

```bash
yarn build && yarn serve
npm run build && npm run serve
```
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@ Build the documentation site locally using the following steps.
2. Install dependencies.

```bash
yarn install
npm install
```

3. Start the development server.

```bash
yarn start
npm start
```

Once the server starts, you can view the documentation at `http://localhost:3000`.
Expand Down
55 changes: 55 additions & 0 deletions eslint.config.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
import react from "eslint-plugin-react";
import tsParser from "@typescript-eslint/parser";
import path from "node:path";
import { fileURLToPath } from "node:url";
import js from "@eslint/js";
import { FlatCompat } from "@eslint/eslintrc";

const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
const compat = new FlatCompat({
baseDirectory: __dirname,
recommendedConfig: js.configs.recommended,
allConfig: js.configs.all
});

export default [{
ignores: [
"build",
"**/.eslintrc.js",
"node_modules/*",
".docusaurus/*",
"**/*.md",
"**/*.mdx",
"static/*",
"*.js",
"*.mjs"
],
}, ...compat.extends("plugin:@docusaurus/recommended"), {
plugins: {
react,
},

languageOptions: {
parser: tsParser,
ecmaVersion: "latest",
sourceType: "module",

parserOptions: {
ecmaFeatures: {
jsx: true,
},

project: ["./tsconfig.json"],
tsconfigRootDir: "./",
},
},

rules: {
"@docusaurus/no-untranslated-text": 0,

"react/no-unknown-property": ["error", {
ignore: ["*"],
}],
},
}];
Loading
Loading