ACT-1296: Infura Faucet Integration in MetaMask Docs #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ACT-1388: Component: Button ACT-1387: Component: Tabs
* ACT-1393 Component: Typography * ACT-1386 Component: Accordion
# Conflicts: # docusaurus.config.js # tsconfig.json
* ACT-1394 Component: Alert + Prettier whole project
* feat(faucet): act-1391 - added badge component * feat(faucet): act-1391 - fix for css vars
|
Metamask:0x84e8277c938102f42FC2D9625Fc75049A86c99Ae |
ACT-1473 Assemble faucet page (#1448)
cedricmagne
dismissed
aednikanov’s stale review
The base branch was changed.
added 2 commits
September 30, 2024 16:40
added 2 commits
September 30, 2024 17:44
TrofimovAnton85
previously approved these changes
Oct 3, 2024
TrofimovAnton85
previously approved these changes
Oct 4, 2024
|
I added a bunch of wording edits to better match our documentation style. Additionally, the faucet works for me, but this is unexpected because I used an address that has had no activity on Ethereum Mainnet (0x2D48e6f5Ae053e4E918d2be53570961D880905F2). Additionally, the transaction history shows that the the transactions are still "pending" even though they went through successfully: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACT-1296 Infura Faucet Integration in MetaMask Docs