Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): act-1451 - fixes for drawer position #1373

Merged
merged 1 commit into from
Jul 1, 2024
Merged

fix(docs): act-1451 - fixes for drawer position #1373

merged 1 commit into from
Jul 1, 2024
+44 −22

Conversation

TrofimovAnton85
Copy link
Collaborator

Description:

  • Improve the Drawer component position on the reference page.

How to test:

  • Go to the test page - /wallet/reference/new-reference
  • Сlick on "Customize request" button & test position of drawer/modal component (It should be inside the content column and follow it on the window width change.)

Screenshot 2024-07-01 at 14 52 36

Links:

JIRA Issue

@TrofimovAnton85 TrofimovAnton85 requested review from a team as code owners July 1, 2024 13:20
@vercel Vercel
Copy link

vercel bot commented Jul 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
metamask-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 1:20pm

joaniefromtheblock
joaniefromtheblock approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@joaniefromtheblock joaniefromtheblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TrofimovAnton85 TrofimovAnton85 merged commit 004085a into main Jul 1, 2024
6 checks passed
@TrofimovAnton85 TrofimovAnton85 deleted the fix-drawer-styles branch July 1, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aednikanov aednikanov aednikanov approved these changes

@joaniefromtheblock joaniefromtheblock joaniefromtheblock approved these changes

@alexandratran alexandratran Awaiting requested review from alexandratran

@bgravenorst bgravenorst Awaiting requested review from bgravenorst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TrofimovAnton85 @aednikanov @joaniefromtheblock