Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Suggested Git Command in Contribution Guidelines #1176

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Update Suggested Git Command in Contribution Guidelines #1176

merged 1 commit into from
Feb 27, 2024

Conversation

subhamkumarr
Copy link
Contributor

@subhamkumarr subhamkumarr commented Feb 26, 2024

Description:

The current contribution guidelines recommend using git add * to stage changes before committing. However, it's more conventional and safer to use git add . to stage changes in the current directory. The difference lies in the behavior of these commands, where git add * stages all changes in the current directory and its subdirectories, potentially including unintended files, while git add . stages changes only in the current directory without including untracked files.

Solution:

Update the contribution guidelines to recommend using git add . instead of git add * for staging changes before committing. This will ensure consistency and help contributors avoid accidentally staging files they didn't intend to include in their commits.

Copy link
Contributor

@joaniefromtheblock joaniefromtheblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alexandratran alexandratran merged commit 9415f1b into MetaMask:main Feb 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants