Feat: refactor to enable additional bridge #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does this relate to #198? |
legobeat
reviewed
Nov 30, 2023
mikesposito
reviewed
Dec 4, 2023
Due to either bridgeOptions or bridgeUrl is not part of account data, it should be removed to remain the bridge configurated by itself but not depend on account Remove deserializeData and serializeData due to same reason Change bridgeUrl to be a object of configuration
legobeat
reviewed
Dec 5, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
legobeat
reviewed
Dec 5, 2023
mikesposito
reviewed
Feb 26, 2024
|
@cryptodev-2s @mikesposito can you merge for me, i dont have the permission to do so |
stanleyyconsensys
dismissed stale reviews from cryptodev-2s and mikesposito
via
1603ab3
legobeat
approved these changes
Feb 27, 2024
mikesposito
pushed a commit
that referenced
this pull request
Aug 27, 2024
- BREAKING: `LedgerIframeBridge` class constructor now takes an options object with `bridgeUrl`. - BREAKING: `LedgerBridge` `init` function now takes no parameters. - BREAKING: `LedgerBridgeKeyringOptions` no longer contain `bridgeUrl`. - BREAKING: `LedgerBridge` interface is now parameterized over its option type - Add `getOptions` and `setOptions` methods to `LedgerBridge` interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ledger is a hardware wallet that support multiple type of integration, it can be integrate by web or by mobile (thought bluetooth)
The current eth-ledger-bridge-keyring is only support web base by using iframe, and the class LedgerKeyring is hardcoded the bridge URL to be passed to lower level bridge
Hence, this PR is focus on enable multi bridge to be integrated into ledger keyring, and moving the bridge specific configuration/parameter into the bridge itself, thus to make the ledger keyring unify