Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SIP-12 with multiple resolutions & optimization #116

Merged
merged 11 commits into from
Feb 1, 2024

Conversation

hmalik88
Copy link
Contributor

@hmalik88 hmalik88 commented Oct 31, 2023

SIP-12 is updated to allow for multiple resolutions across different protocols. Snaps can also now identify the TLDs they support.

Note: In the future, the protocol string type will be further narrowed to a CAIP resolution protocol identifier. See ChainAgnostic/CAIPs#253

…ls, let a snap identify the TLDs it supports
@hmalik88 hmalik88 requested review from Montoya, ziad-saab and a team as code owners October 31, 2023 19:53
SIPS/sip-12.md Outdated Show resolved Hide resolved
SIPS/sip-12.md Outdated Show resolved Hide resolved
SIPS/sip-12.md Show resolved Hide resolved
SIPS/sip-12.md Show resolved Hide resolved
@kenhkan
Copy link

kenhkan commented Dec 14, 2023

@hmalik88 We've put this in the backlog for now. Please update the group on the status when you return. Thank you!

@hmalik88
Copy link
Contributor Author

@kenhkan this needs further review, I responded to Frederik's comments.

SIPS/sip-12.md Outdated Show resolved Hide resolved
SIPS/sip-12.md Outdated Show resolved Hide resolved
SIPS/sip-12.md Outdated Show resolved Hide resolved
SIPS/sip-12.md Outdated Show resolved Hide resolved
SIPS/sip-12.md Outdated Show resolved Hide resolved
SIPS/sip-12.md Outdated Show resolved Hide resolved
@bumblefudge
Copy link

Hey, a DM from another MMer reminded me that I owe you review over on the CASA side! Is work continuing on this? where can i be helpful?

Quick question: how does this work for SUBDOMAINS? could sismo.eth be an entry in the TLD array, or are . characters excluded from it? Just wondering because I remember during peak ENS excitement days there were all these subdomain/sublease schemes...

@hmalik88
Copy link
Contributor Author

Hey, a DM from another MMer reminded me that I owe you review over on the CASA side! Is work continuing on this? where can i be helpful?

Quick question: how does this work for SUBDOMAINS? could sismo.eth be an entry in the TLD array, or are . characters excluded from it? Just wondering because I remember during peak ENS excitement days there were all these subdomain/sublease schemes...

Hmm to get a subdomain working you can technically do sismo.eth as a scheme in the schemes array!

I've paused work on the CAIP, I have to re-evaluate it's need in the future (domain lookup w/o that spec is fine in MM and I don't think anyone else in the space is thinking about this problem in depth yet 😄)

bowensanders
bowensanders previously approved these changes Jan 30, 2024
Copy link

@bowensanders bowensanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SIPS/sip-12.md Outdated Show resolved Hide resolved
SIPS/sip-12.md Outdated Show resolved Hide resolved
@hmalik88 hmalik88 merged commit d730ab2 into main Feb 1, 2024
3 checks passed
@hmalik88 hmalik88 deleted the hm/SIP-12-optimization branch February 1, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants