Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Implement Protocol Buffers Template #215

Open
1 task done
H0llyW00dzZ opened this issue Apr 5, 2024 · 5 comments
Open
1 task done

[Feature Request] Implement Protocol Buffers Template #215

H0llyW00dzZ opened this issue Apr 5, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@H0llyW00dzZ
Copy link
Contributor

H0llyW00dzZ commented Apr 5, 2024

Tell us about your feature request

Implement a protocol buffers template for advance only

Disclaimer

  • I agree
@H0llyW00dzZ H0llyW00dzZ added the enhancement New feature or request label Apr 5, 2024
@H0llyW00dzZ H0llyW00dzZ changed the title [Feature Request] Protocol Buffer Template [Feature Request] Implement Protocol Buffer Template Apr 5, 2024
@H0llyW00dzZ H0llyW00dzZ changed the title [Feature Request] Implement Protocol Buffer Template [Feature Request] Implement Protocol Buffers Template Apr 5, 2024
@Ujstor
Copy link
Collaborator

Ujstor commented Apr 5, 2024

We would like to see gRPC implemented as an advanced feature. There was a ticket in the early days, but it was never delivered #31

Twirp is good choice https://github.com/twitchtv/twirp

@H0llyW00dzZ
Copy link
Contributor Author

We would like to see gRPC implemented as an advanced feature. There was a ticket in the early days, but it was never delivered #31

Twirp is good choice https://github.com/twitchtv/twirp

@Ujstor I also have an example for Proto:

https://github.com/h0llyW00dzZ/ProtoHTTP

It uses the packages google/api/annotations.proto and google/rpc/status.proto, which are enough to create REST APIs.

@H0llyW00dzZ
Copy link
Contributor Author

Also, note that Protocol Buffers have a limitation that I am still figuring out.
For example:

{
  "latencyMicroseconds": "101579",
  "formattedLatency": "101579 µs",
  "formattedLatencyMilliseconds": "101.58 ms"
}

The latencyMicroseconds, formattedLatency, and formattedLatencyMilliseconds cannot be customized by changing them into:

{
  "latency_microseconds": "101579",
  "formatted_latency": "101579 µs",
  "formatted_latency_milliseconds": "101.58 ms"
}

because it seems to be automatic or dynamic.

@Ujstor
Copy link
Collaborator

Ujstor commented Apr 6, 2024

@H0llyW00dzZ , I have never used gRPC and don't know enough to make this decision. @Melkeydev is the best person to ask how he envisions implementing it within the advanced flag.

@H0llyW00dzZ
Copy link
Contributor Author

@H0llyW00dzZ , I have never used gRPC and don't know enough to make this decision. @Melkeydev is the best person to ask how he envisions implementing it within the advanced flag.

@Ujstor, it's pretty useful for large applications, and highly performant and scalable. I can understand why Google uses protocol buffers for gRPC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants