Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] GRPC support #246

Open
1 task done
syedolive opened this issue Jun 2, 2024 · 7 comments
Open
1 task done

[Feature Request] GRPC support #246

syedolive opened this issue Jun 2, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@syedolive
Copy link

Tell us about your feature request

Hi maintainers, first of all love the boilerplate. Just started with Go few weeks ago. I was wondering if a Grpc setup can be added to it just like nestjs does. I know that's a framework and all but since its generating a set of tools to get started quickly like a framework does in a sense. Would It be possible? Its a good to have IMO.

Disclaimer

  • I agree
@syedolive syedolive added the enhancement New feature or request label Jun 2, 2024
@H0llyW00dzZ
Copy link
Contributor

Tell us about your feature request

Hi maintainers, first of all love the boilerplate. Just started with Go few weeks ago. I was wondering if a Grpc setup can be added to it just like nestjs does. I know that's a framework and all but since its generating a set of tools to get started quickly like a framework does in a sense. Would It be possible? Its a good to have IMO.

Disclaimer

  • I agree

It is possible; however, GRPC is unlike other. It has some limitations, especially for code generation using protoc.

If you are looking to get started quickly, you can take a look at my repository about GRPC/PROTO here.

@Ujstor
Copy link
Collaborator

Ujstor commented Jun 3, 2024

We are on board if somebody wants to implement it in Blueprint as an Advanced flag.

https://github.com/twitchtv/twirp Seems like a good framework to go with.

There is also another ticket where we discussed this #215

@syedolive
Copy link
Author

Tell us about your feature request

Hi maintainers, first of all love the boilerplate. Just started with Go few weeks ago. I was wondering if a Grpc setup can be added to it just like nestjs does. I know that's a framework and all but since its generating a set of tools to get started quickly like a framework does in a sense. Would It be possible? Its a good to have IMO.

Disclaimer

  • I agree

It is possible; however, GRPC is unlike other. It has some limitations, especially for code generation using protoc.

If you are looking to get started quickly, you can take a look at my repository about GRPC/PROTO here.

Hey man, I do have grpc setup and since I use Ubuntu, protoc is not a problem for me. I just thought having a setup for grpc and providing protoc instructions at the end of the installations would be cool. I'm pretty sure people working with go are mature enough to set those up by themselves.

@syedolive
Copy link
Author

We are on board if somebody wants to implement it in Blueprint as an Advanced flag.

https://github.com/twitchtv/twirp Seems like a good framework to go with.

There is also another ticket where we discussed this #215

I'm gonna look into it. I'm fairly new to go but GRPC is universal for me like json as I have been using grpc communication from Nestjs to go. And since we're planning for a transition to go and replacing smaller service to go. This blueprint would be a heaven breeze for me.

@Ujstor
Copy link
Collaborator

Ujstor commented Jun 5, 2024

Perfect, I am assigning this to you. Implementation needs to integrate into the overall project without conflicting with other components. Some way for the user to test the endpoint would be nice. The goal is to showcase how to integrate gRPC and provide a starting point.

@ashupednekar
Copy link
Contributor

ashupednekar commented Jun 11, 2024

Hi, if we can figure out a way to keep the generated pb wrappers in an abstracted manner, should be doable.
I've done something similar for python (link).

Should be cleaner and simpler in go cuz of the package structure... shall I give it a go ?

@utamori
Copy link

utamori commented Aug 6, 2024

It is a good idea to adopt connect-go.

It supports grpc, grpc-web and its own connect-rpc (an improved version of grpc-web)
and is available in standard net/http and other frameworks

https://github.com/connectrpc/connect-go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants