Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows GUI: Update installers #989

Merged
merged 3 commits into from
Dec 7, 2024
Merged

Conversation

cjee21
Copy link
Collaborator

@cjee21 cjee21 commented Dec 6, 2024

Add ARM64 to all-in-one installer and update the other scripts for consistent layout.

@cjee21
Copy link
Collaborator Author

cjee21 commented Dec 6, 2024

@JeromeMartinez adding Windows 11 ARM64 support to combined/all-in-one installer increases size by roughly 3.5MiB (excluding digital signatures). I think it is acceptable. If want to really save bandwidth can use the online installer and only use combined/all-in-one when offline install is needed.

@JeromeMartinez JeromeMartinez merged commit 946b9a8 into MediaArea:master Dec 7, 2024
3 checks passed
@JeromeMartinez
Copy link
Member

adding Windows 11 ARM64 support to combined/all-in-one installer increases size by roughly 3.5MiB (excluding digital signatures). I think it is acceptable. I

I am fine with that.
By the way, the ARM64_WithoutInstaller.7z is missing.

@cjee21 cjee21 deleted the NSIS branch December 7, 2024 11:08
@cjee21
Copy link
Collaborator Author

cjee21 commented Dec 7, 2024

By the way, the ARM64_WithoutInstaller.7z is missing.

This one?

🤔 What went wrong? It is called here and copied here.

I checked my local build and MediaInfo_GUI_Windows_ARM64_WithoutInstaller.7z is present with correct files.

@JeromeMartinez
Copy link
Member

I checked my local build and MediaInfo_GUI_Windows_ARM64_WithoutInstaller.7z is present with correct files.

I launched a new build, we'll see.

@g-maxime
Copy link
Contributor

g-maxime commented Dec 7, 2024

adding Windows 11 ARM64 support to combined/all-in-one installer increases size by roughly 3.5MiB (excluding digital signatures). I think it is acceptable. I

I am fine with that. By the way, the ARM64_WithoutInstaller.7z is missing.

Fixed in the CI now.

@JeromeMartinez
Copy link
Member

@rednoah please test this snapshot.
This should be our final work on Windows 11 ARM64 support: DLL, CLI including remote (https) file support, hybrid GUI (no need of complete ARM64 support as the slow part is in the DLL and the DLL is native) including explorer extension & tooltip.

@cjee21
Copy link
Collaborator Author

cjee21 commented Dec 8, 2024

Windows 11 ARM64 support: DLL

For DLL maybe can distribute ARM64X too since already building it for the GUI so that third party apps using MediaInfoLib that are still x64 can benefit from native performance when emulated on ARM64.

@JeromeMartinez
Copy link
Member

For DLL maybe can distribute ARM64X too since already building it for the GUI

I'll discuss about that with the team tomorrow, we have already several packages, but at the least we can indicate to potential users that they can pick the DLL from the the GUI ZIP.

@rednoah
Copy link

rednoah commented Dec 9, 2024

@rednoah please test this snapshot. This should be our final work on Windows 11 ARM64 support: DLL, CLI including remote (https) file support, hybrid GUI (no need of complete ARM64 support as the slow part is in the DLL and the DLL is native) including explorer extension & tooltip.

Happy to confirm that everything works. GUI starts. Windows Explorer tooltip and context menu works. DLL can be loaded from my tools as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants