Qt GUI Improvements

[cjee21]

A collection of improvements made while I was exploring the Qt version of MediaInfo.

• Use MSVC2022 for building the x86_64 Windows build
  • Changes to project file to successfully build using MSVC2022 including fixes for linker errors due to path issues
• Enable Control Flow Guard (CFG) for x86_64 Windows build
  • Enables CFG as strongly encouraged by Microsoft.
  • For full protection, MediaInfoLib, ZenLib and zlib should be built with /guard:cf enabled in Project | Properties | Configuration Properties | C/C++ | Code Generation of their respective Visual Studio Projects.
• Reverts commit 18b6e3c
  • This commit it is not cross-platform and causes missing icons in both Windows and Ubuntu.
• Use newer 'Close' icon when available
  • Uses newer QIcon::fromTheme(QIcon::ThemeIcon::WindowClose) when built with Qt > 6.7
  • This newer icon is visible in dark mode on Windows unlike previous one.
• Prefer Cascadia Mono font when available
  • For systems with Cascadia Mono font (the default font for Windows Terminal) installed, it will be used else old font selection behaviour is maintained.
  • Cascadia Mono is more readable than the previously selected font on Windows and is also consistent with current VCL version of MediaInfo.
• Prevent toolbar from being moved
  • Previously, it was possible to detach the toolbar.
• Prevent clipped text in easy view
  • Make it resize properly to prevent clipped text in easy view when viewing certain files with multi-line metadata due to text wrap.
• Other improvements
  • Remove unused includes in mainwindow.cpp.
  • Fix inconsistent indents in mainwindow.cpp.

Tested with Qt 6.7.2 and MSVC2022.

Windows 11 screenshots:

Process Explorer showing 64-bit Qt version with DEP, ASLR, CFG and Per-monitor DPI Awareness enabled

Ubuntu screenshots:

Previous screenshots for comparison:
#857 (comment)
#857 (comment)

[JeromeMartinez]

A collection of improvements made while I was exploring the Qt version of MediaInfo.

Thank you so much, we didn't yet have the time to focus on such improvement and it is great that a third party uses the possibilities of open source for improving MediaInfo, and that you take the time to deeply test the results, we know that it is a lot of time.

Use MSVC2022 for building the x86_64 Windows build

I prefer to keep a coherence so to change that everywhere.
About $$PWD, what is the issue without it? It seems to work well without it.

Enable Control Flow Guard (CFG) for x86_64 Windows build

Beside Qt project, if you don't mind, please check, enable if needed, test and send another PR for VS2022 as well as VS2019 (we didn't yet upgraded VS on our build farm), for all repositories. Nothing mandatory if you don't want to do that, just a wish.

As we are there, you may be curious about CET, and try CET option. As we don't have a CPU supporting CET, we didn't try but it would be great if it is doable.

[cjee21]

I prefer to keep a coherence so to change that everywhere.

I can change for others as well but it will be untested.

About $$PWD, what is the issue without it? It seems to work well without it.

Without this I get many linker errors of things not found during the linking stage.

Beside Qt project, if you don't mind, please check, enable if needed, test and send another PR for VS2022 as well as VS2019 (we didn't yet upgraded VS on our build farm), for all repositories. Nothing mandatory if you don't want to do that, just a wish.

I'll see what I can do when I'm free.

As we are there, you may be curious about CET, and try CET option. As we don't have a CPU supporting CET, we didn't try but it would be great if it is doable.

My CPU seems supported. I'll check it out.

There is also Spectre mitigations but I'm not sure if relevant for MediaInfo. This one is known to affect performance. This one is enabled in my Windows 11 context menu PoC.

[JeromeMartinez]

I can change for others as well but it will be untested.

Similar update so I take the risk :).

Without this I get many linker errors of things not found during the linking stage.

Weird, Fedora uses it and seems fine, @g-maxime can you check that mediainfo-qt package still compiles on Fedora?

There is also Spectre mitigations but I'm not sure if relevant for MediaInfo. This one is known to affect performance.

IMO the "cost" of this option is higher than the benefit we may have with it, so I wouldn't add it until they find a less impacting mitigation.

[cjee21]

Weird, Fedora uses it and seems fine, @g-maxime can you check that mediainfo-qt package still compiles on Fedora?

Only affects Windows MSVC as far as I know. It built fine on Ubuntu without any changes.

[JeromeMartinez]

Only affects Windows MSVC as far as I know. It built fine on Ubuntu without any changes.

Oops, true, so @g-maxime no need to test.

[cjee21]

It works! :D

Tested on AMD CPU.

[cjee21]

Beside Qt project, if you don't mind, please check, enable if needed, test and send another PR for VS2022 as well as VS2019 (we didn't yet upgraded VS on our build farm), for all repositories. Nothing mandatory if you don't want to do that, just a wish.

PRs created for MediaInfoLib, ZenLib and zlib.

Also for MediaInfo CLI. There are probably other MSVC Projects which I did not touch because I do not know their purpose.

[cjee21]

FYI The HTML view in Qt version already has proper dark mode support on Windows.

EDIT: This is before the HTML patch for MediaInfoLib. It has extra cells on the first row. Can't find why it displays so many borders.

[cjee21]

PRs created for MediaInfoLib, ZenLib and zlib.

Also for MediaInfo CLI. There are probably other MSVC Projects which I did not touch because I do not know their purpose.

@JeromeMartinez
Confirmed that most recent dev build has CFG and CET enabled for MediaInfo DLLs and CLI