Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Russian translation #807

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

JeromeMartinez
Copy link
Member

No description provided.

@JeromeMartinez
Copy link
Member Author

@slichtzzz there is an update proposal from someone else, please review the change proposals.

@slichtzzz
Copy link
Contributor

Fine work, for the most part. A few new strings, corrected typos, for some of the strings apparently did better job, than I.
At the same time, many unnecessary synonymous replacements, which I am reasonably not against. And to very few of it I would strongly oppose. And finally couple strings miss correct orthography.

Is it better to accept it now, so that later I would be able to propose my corrections to this new version?

@JeromeMartinez
Copy link
Member Author

@slichtzzz please comment directly on GitHub ("review" all comments in one shot) and I'll forward the comments to the other person.

@slichtzzz
Copy link
Contributor

So, I think that's it

@JeromeMartinez
Copy link
Member Author

So, I think that's it

?
No comment sent.
(maybe you didn't click on "send review" in "review changes" box on the top right)

@slichtzzz
Copy link
Contributor

Well, there's a green "Review changes" button, but it doesn't do anything when I press it.

Maybe because there are exactly 13 comments ))

@JeromeMartinez
Copy link
Member Author

Well, there's a green "Review changes" button, but it doesn't do anything when I press it.

It should open the small box, then click on "Submitreview".

image

Source/Resource/Plugin/Language/ru.csv Outdated Show resolved Hide resolved
Source/Resource/Plugin/Language/ru.csv Outdated Show resolved Hide resolved
Source/Resource/Plugin/Language/ru.csv Outdated Show resolved Hide resolved
Source/Resource/Plugin/Language/ru.csv Outdated Show resolved Hide resolved
Source/Resource/Plugin/Language/ru.csv Outdated Show resolved Hide resolved
Source/Resource/Plugin/Language/ru.csv Show resolved Hide resolved
Source/Resource/Plugin/Language/ru.csv Show resolved Hide resolved
Source/Resource/Plugin/Language/ru.csv Show resolved Hide resolved
Source/Resource/Plugin/Language/ru.csv Show resolved Hide resolved
Source/Resource/Plugin/Language/ru.csv Show resolved Hide resolved
@slichtzzz
Copy link
Contributor

Didn't do this in Chromium-Gost, but finally done it in Firefox )

@JeromeMartinez JeromeMartinez merged commit 91dd652 into MediaArea:master Feb 23, 2024
3 checks passed
@JeromeMartinez JeromeMartinez deleted the Language_ru branch February 23, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants