Merge pull request #976 from cjee21/uninstaller-signing

Windows GUI: Implement signing of uninstaller
MediaArea · Nov 26, 2024 · 6dd4098 · 6dd4098
2 parents 54eb175 + 1685c02
commit 6dd4098
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 0 deletions.
diff --git a/Source/Install/MediaInfo_GUI_Windows.nsi b/Source/Install/MediaInfo_GUI_Windows.nsi
@@ -37,6 +37,10 @@ SetCompressor /FINAL /SOLID lzma
 !include "MUI2.nsh"
 !define MUI_ABORTWARNING
 !define MUI_ICON "..\..\Source\Resource\Image\MediaInfo.ico"
+!define MUI_UNICON "..\..\Source\Resource\Image\MediaInfo.ico"
+
+; Uninstaller signing
+!uninstfinalize 'sign.cmd "%1" "MediaInfo Uninstaller"'
 
 ; Language Selection Dialog Settings
 !define MUI_LANGDLL_REGISTRY_ROOT "${PRODUCT_UNINST_ROOT_KEY}"

diff --git a/Source/Install/MediaInfo_GUI_Windows_i386.nsi b/Source/Install/MediaInfo_GUI_Windows_i386.nsi
@@ -34,6 +34,10 @@ SetCompressor /FINAL /SOLID lzma
 !include "MUI2.nsh"
 !define MUI_ABORTWARNING
 !define MUI_ICON "..\..\Source\Resource\Image\MediaInfo.ico"
+!define MUI_UNICON "..\..\Source\Resource\Image\MediaInfo.ico"
+
+; Uninstaller signing
+!uninstfinalize 'sign.cmd "%1" "MediaInfo Uninstaller"'
 
 ; Language Selection Dialog Settings
 !define MUI_LANGDLL_REGISTRY_ROOT "${PRODUCT_UNINST_ROOT_KEY}"

diff --git a/Source/Install/MediaInfo_GUI_Windows_x64.nsi b/Source/Install/MediaInfo_GUI_Windows_x64.nsi
@@ -37,6 +37,10 @@ SetCompressor /FINAL /SOLID lzma
 !include "MUI2.nsh"
 !define MUI_ABORTWARNING
 !define MUI_ICON "..\..\Source\Resource\Image\MediaInfo.ico"
+!define MUI_UNICON "..\..\Source\Resource\Image\MediaInfo.ico"
+
+; Uninstaller signing
+!uninstfinalize 'sign.cmd "%1" "MediaInfo Uninstaller"'
 
 ; Language Selection Dialog Settings
 !define MUI_LANGDLL_REGISTRY_ROOT "${PRODUCT_UNINST_ROOT_KEY}"

diff --git a/Source/Install/sign.cmd b/Source/Install/sign.cmd
@@ -0,0 +1,5 @@
+set /P CodeSigningCertificatePass= < %USERPROFILE%\CodeSigningCertificate.pass
+if "%NOSIGN%"=="" (
+    signtool.exe sign /f %USERPROFILE%\CodeSigningCertificate.p12 /p %CodeSigningCertificatePass% /fd sha256 /v /tr http://ts.ssl.com /td sha256 /d %2 /du http://mediaarea.net %1
+)
+set CodeSigningCertificatePass=