Reload GaugeChart when nedleValue option is changed #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reload GaugeChart when nedleValue option is changed.
Use updateNeedle when only needleValue is changed.
|
When the needleValue option is changed, the updateNeedle method is called on the GaugeChart instance. If the centralLabel option is changed with the needleValue option, the GaugeChart instance is removed and created again. Fixes #1 |
|
This works fine, can the author of this repo please merge and make a release with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When needleValue option is changed, the GaugeChart instance is removed and created again with the new value. The GaugeChart.updateNeedle method only updates needle position, but if you need to update needle position with the centralLabel option, the GaugeChart instance has to be removed and created again.