Add support for bespoke MRM formatting in read_lfs_datacube
#255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@angusmoore you absolute legend! Sorry it's taken me a while to get to this |
|
No problem at all, happy to help! test failures look unrelated? Tests were passing locally ( |
|
sorry for the radio silence @angusmoore - I'll fix this up |
|
No problem at all! |
erge branch 'master' into anm/mrm
|
Merging this now @angusmoore. I fixed the (unrelated) problems that were causing tests to fail, and added you as a contributor in DESCRIPTION |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New MRM datacube has a new and exciting format. This adds custom parsing logic for those tables, by adding an if-then in
read_lfs_datacubeto detect MRM and dump out to separate parsing logic.Closes this tweet: https://x.com/MattCowgill/status/1806467970740486518
Thoughts/changes on returned dataframe structure of course welcome.