Python: Add support for arbitrary sequences of hashable objects #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround until Martinsos#90 is implemented. If either query or target contain non-ascii values, they are mapped into an ASCII alphabet and the resulting byte sequences are used for doing the alignment.
jbaiter
force-pushed
the
python-unicode-workaround
branch
from
f3d27be
to
08b8e0a
Compare
|
@jbaiter thanks this is very cool :)! |
Martinsos
requested changes
Mar 17, 2019
- Refactor input mapping code into separate function - Allow no more than 256 unique values (was: 255) - Also map additional equalities if query or target need mapping - Update docstrings - Fix code style
jbaiter
force-pushed
the
python-unicode-workaround
branch
from
ddc5975
to
2478821
Compare
|
Thanks for the thorough review! |
Martinsos
reviewed
Mar 23, 2019
Martinsos
approved these changes
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements @Martinsos' suggestion from #79 to add support for sequences of arbitrary hashable objects in the Python bindings. If either query or target contain non-ascii values, they are mapped into an ASCII alphabet and the resulting byte sequences are used for doing the alignment.
One limitation that we can't get around at the moment is that the query and target sequence together must not contain more than 256 unique values.
It certainly is not the ideal way to go about this, but it should serve as an acceptable workaround for a lot of use cases until #90 is implemented.
This should help with #123, #114, #109, #104, #89 and #79.