-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MDEV-35398 Improve shrinking of system tablespace #3632
Open
Thirunarayanan
wants to merge
1
commit into
11.4
Choose a base branch
from
11.2-MDEV-35398
base: 11.4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+89
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thirunarayanan
force-pushed
the
11.2-MDEV-35398
branch
from
November 13, 2024 18:21
6715076
to
315f9b4
Compare
Thirunarayanan
force-pushed
the
11.2-MDEV-35398
branch
from
November 14, 2024 04:33
315f9b4
to
8e37174
Compare
dr-m
reviewed
Nov 14, 2024
dr-m
reviewed
Nov 14, 2024
Thirunarayanan
force-pushed
the
11.2-MDEV-35398
branch
from
November 14, 2024 12:38
8e37174
to
c285d90
Compare
dr-m
reviewed
Nov 14, 2024
Thirunarayanan
force-pushed
the
11.2-MDEV-35398
branch
from
November 14, 2024 15:27
c285d90
to
ca4a15c
Compare
Problem: ======== From 10.6.13(86767bc) version, InnoDB purge thread does free the TRX_UNDO_CACHED undo segment. Pre-10.6.13 version data directory can contain TRX_UNDO_CACHED undo segment in system tablespace even though it has external undo tablespace. During slow shutdown, InnoDB collects the segment from tables exist in system tablespace and cached undo segment in the system tablespace as used segment exist in system tablespace. While shrinking the system tablespace, last used extent can be used by undo cached segment. This extent blocks the shrinking of system tablespace in a effective way. Solution: ======== While freeing the unused segment, InnoDB should free the cached undo segment header page exists in system tablespace and reset the TRX_RSEG_UNDO_SLOTS to 0xff for the rollback segment header page exists in system tablespace. This could improve the shrinking of system tablespace further.
Thirunarayanan
force-pushed
the
11.2-MDEV-35398
branch
from
November 14, 2024 15:34
ca4a15c
to
70b0438
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem:
From 10.6.13(86767bc) version, InnoDB purge thread does free the TRX_UNDO_CACHED undo segment. Pre-10.6.13 version data directory can contain TRX_UNDO_CACHED undo segment in system tablespace even though it has external undo tablespace.
During slow shutdown, InnoDB collects the segment from tables exist in system tablespace and cached undo segment in the system tablespace as used segment exist in system tablespace. While shrinking the system tablespace, last used extent can be used by undo cached segment. This extent blocks the shrinking of system tablespace in a effective way.
Solution:
While freeing the unused segment, InnoDB should free the cached undo segment header page exists in system tablespace and reset the TRX_RSEG_UNDO_SLOTS to 0xff for the rollback segment header page exists in system tablespace. This could improve the shrinking of system tablespace further.
How can this PR be tested?
./mtr innodb.undo_leak --mem
Basing the PR against the correct MariaDB version
main
branch.PR quality check