Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconnect existing ISO Datastores #624

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

agrare
Copy link
Member

@agrare agrare commented Dec 15, 2022

The previous iso_datastores table did not have an ems_ref but there could only be a single ISO Datastore so we can just pick that.

@agrare agrare requested a review from Fryguy as a code owner December 15, 2022 20:05
@agrare agrare added the wip label Dec 15, 2022
@miq-bot miq-bot removed the wip label Dec 15, 2022
@Fryguy Fryguy added the bug label Jan 4, 2023
@miq-bot
Copy link
Member

miq-bot commented Apr 10, 2023

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

1 similar comment
@miq-bot
Copy link
Member

miq-bot commented Apr 10, 2023

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@kbrock kbrock removed the stale label May 24, 2023
@kbrock
Copy link
Member

kbrock commented May 24, 2023

test failure seems legit.

@agrare agrare force-pushed the reconnect_iso_datastores branch from c6a441b to b656737 Compare May 24, 2023 20:12
@miq-bot
Copy link
Member

miq-bot commented May 24, 2023

Checked commit agrare@b656737 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
1 file checked, 1 offense detected

app/models/manageiq/providers/ovirt/inventory/persister/infra_manager.rb

  • ⚠️ - Line 74, Col 96 - Lint/UnusedBlockArgument - Unused block argument - attributes_index. If it's necessary, use _ or _attributes_index as an argument name to indicate that it won't be used.

@nasark
Copy link
Member

nasark commented May 25, 2023

We need to figure out why we have >1 iso datastores in our VCRs and/or confirm if it is possible to have more than one iso datastore in the first place.

@miq-bot miq-bot added the stale label Aug 28, 2023
@miq-bot
Copy link
Member

miq-bot commented Aug 28, 2023

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@agrare agrare added pinned and removed stale labels Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants