Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow axes to be constructed by namedtuple syntax in Map #118

Merged
merged 8 commits into from
Dec 25, 2024

Conversation

asinghvi17
Copy link
Member

Allows

b = Rect2f(-20.0, -20.0, 40.0, 40.0)
m = Tyler.Map(b, provider=OpenStreetMap(), axis = (; type = GeoAxis))

f = Figure()
m = Tyler.Map(b, provider = OpenStreetMap(), figure = f[1, 2])

src/map.jl Show resolved Hide resolved
Copy link
Collaborator

@rafaqz rafaqz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I wanted this the other day instead of setting up a GeoAxis manually

@lazarusA
Copy link
Collaborator

One test is failing 😔

Base automatically changed from geomakie to master December 23, 2024 13:13
test/runtests.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
@asinghvi17
Copy link
Member Author

This needs a rebase, let's not merge yet

@asinghvi17
Copy link
Member Author

Ok...I have no clue what's going on with this segfault :(

@asinghvi17
Copy link
Member Author

asinghvi17 commented Dec 24, 2024

We could also add an LMap, as a way to switch away from requiring control over the figure. But that's out of scope for this release (v0.2.1).

@asinghvi17
Copy link
Member Author

It looks like the segfault is a known error in the interaction between julia and curl:

curl/curl#14860

so I think we can merge as is. Doc build failed for external reasons (I think)...

@asinghvi17 asinghvi17 merged commit 32ab5aa into master Dec 25, 2024
0 of 3 checks passed
@asinghvi17 asinghvi17 deleted the as/axiskws branch December 25, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants