Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eeg_topoplot labels fix #54

Merged
merged 14 commits into from
Nov 15, 2024
Merged

eeg_topoplot labels fix #54

merged 14 commits into from
Nov 15, 2024

Conversation

behinger
Copy link
Collaborator

As of now, the labels in the eeg_topoplot have not every worked (strange, but oh well..).

In any case, I fixed this now, but I also moved labels from a positional argument to a keyword argument. I think this makes much more sense, you can either specify positions, labels or both.

One argument could be made to make positions a positional argument, like in topoplot itself and overload it, but I didnt manage with convert argument, and I think this way it is ok.

This is a breaking change.

PS: I might want to adress few other issues which might be breaking too (e.g. #38), so please hold with new version

@palday
Copy link
Collaborator

palday commented Sep 30, 2024

can you go ahead and bump to version 0.2.0-DEV to remind us that there is a breaking change here but we don't yet want to release?

docs/src/eeg.md Outdated Show resolved Hide resolved
docs/src/eeg.md Outdated Show resolved Hide resolved
docs/src/topo_series.jl Outdated Show resolved Hide resolved
src/TopoPlots.jl Outdated Show resolved Hide resolved
src/eeg.jl Outdated Show resolved Hide resolved
src/eeg.jl Outdated Show resolved Hide resolved
src/eeg.jl Outdated Show resolved Hide resolved
src/eeg.jl Show resolved Hide resolved
src/eeg.jl Outdated Show resolved Hide resolved
@behinger
Copy link
Collaborator Author

behinger commented Oct 24, 2024

Thanks for the review, I finally adressed/fixed/took over all the issues. thanks!

1 finished, 3 more to go!

@palday palday merged commit 4d6a64c into master Nov 15, 2024
2 checks passed
@palday palday deleted the label_fix branch November 15, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants