-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eeg_topoplot labels fix #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can you go ahead and bump to version |
palday
reviewed
Sep 30, 2024
palday
reviewed
Sep 30, 2024
palday
reviewed
Sep 30, 2024
palday
reviewed
Sep 30, 2024
palday
reviewed
Sep 30, 2024
palday
reviewed
Sep 30, 2024
palday
reviewed
Sep 30, 2024
palday
reviewed
Sep 30, 2024
palday
reviewed
Sep 30, 2024
Co-authored-by: Phillip Alday <[email protected]>
Thanks for the review, I finally adressed/fixed/took over all the issues. thanks! 1 finished, 3 more to go! |
palday
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, the labels in the eeg_topoplot have not every worked (strange, but oh well..).
In any case, I fixed this now, but I also moved
labels
from a positional argument to a keyword argument. I think this makes much more sense, you can either specify positions, labels or both.One argument could be made to make positions a positional argument, like in
topoplot
itself and overload it, but I didnt manage with convert argument, and I think this way it is ok.This is a breaking change.
PS: I might want to adress few other issues which might be breaking too (e.g. #38), so please hold with new version