Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip minorticks when they are not shown #4681

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Dec 18, 2024

Description

Fixes #4608

Skips minortick generation when they are not shown.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

@ffreyer
Copy link
Collaborator Author

ffreyer commented Dec 18, 2024

I checked that

f = Figure(size = (200, 200))
a = Axis(f[1, 1], yticksmirrored = true, yticksize = 10, ytickwidth = 4, spinewidth = 5, yminortickcolor = :red)
Colorbar(f[1, 2])
display(f)
a.yminorticksvisible[] = true

works without update problems

@MakieBot
Copy link
Collaborator

MakieBot commented Dec 18, 2024

Benchmark Results

SHA: ff7099edb424b7e894531a1c6e2ae603f673e86e

Warning

These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.

GLMakie
CairoMakie
WGLMakie

@ffreyer ffreyer marked this pull request as ready for review December 18, 2024 19:14
@ffreyer
Copy link
Collaborator Author

ffreyer commented Dec 18, 2024

May help #4593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready to review
Development

Successfully merging this pull request may close these issues.

Slow and excessive allocation in density and xticks
2 participants