Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Float32 constraints in poly pipeline #4615

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

asinghvi17
Copy link
Member

Description

Fixes #4267

Harvests type-level float type (T) and dimensionality (N) information down the poly pipeline so we can assign meshes the correct types.

With this changeset, this MWE now works.

polygons = Observable(Polygon{2,Float64}[])
poly(polygons)
push!(polygons[], Polygon([Point(1.0, 2.0), Point(2.0, 3.0), Point(3.0, 2.0)]))
notify(polygons)

This needs a slight change for GeometryBasics v0.5, which I'm happy to PR to the breaking-v0.22 branch if we do merge this to master. This also fixes the upstream bug in MakieDraw.

Type of change

Delete options that do not apply:

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Added an entry in CHANGELOG.md (for new features and breaking changes)
  • Added or changed relevant sections in the documentation
  • Added unit tests for new algorithms, conversion methods, etc.
  • Added reference image tests for new plotting functions, recipes, visual options, etc.

Also fix dimensionality constraints
@asinghvi17 asinghvi17 self-assigned this Nov 21, 2024
@asinghvi17 asinghvi17 added bug mesh (and poly) labels Nov 21, 2024
@asinghvi17 asinghvi17 marked this pull request as ready for review November 21, 2024 20:01
@MakieBot
Copy link
Collaborator

Benchmark Results

SHA: 7187d4cd961f6836b3cc278580496de108980e7f

Warning

These results are subject to substantial noise because GitHub's CI runs on shared machines that are not ideally suited for benchmarking.

GLMakie
CairoMakie
WGLMakie

@ffreyer
Copy link
Collaborator

ffreyer commented Nov 22, 2024

I'd rather have this based on breaking since we are planning to merge that soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug mesh (and poly)
Projects
Status: Work in progress
Development

Successfully merging this pull request may close these issues.

Types not detected correctly from emtpy typed vectors of polygons
3 participants