-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
turn GeoAxis into a block and fix projection #148
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Will be useful for when we know which limits projections have
Current TODO list is:
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs: MakieOrg/Makie.jl#2645
This changes the axis to use a manual
Makie.@Block
macro, to re-create something similar toMakie.Axis
, without creating a wholeMakie.Axis
.Enables:
chose
axis=(; type=GeoAxis)
and pass all other axis attributes like that:lines(GeoMakie.coastlines(); axis=(; type=GeoAxis))
Plots now can pass
source=source_data_projection
, to allow for different input source projectionslines!(axis, ..., source="+proj=longlat +datum=WGS84")
source_projection = "+proj=longlat +datum=WGS84"
andtarget_projection = "+proj=eqearth"
create_transform(dest::String, source::String)
for other projection types thenProj
+ stringsintercepts poly call to create triangulation after projection, removing incorrect triangulations form distorting projections
the GeoAxis now doesn't have it's own transform_func, and just works on "normal" 2d data, getting rid of all the limit problems (instead, the plot data gets it's own transformation and get transformed before plotting)
TODOs
apply_transform
... But I think we'll need to make the split function projection aware for that first?Stretch goal
Makie/makielayout/blocks/axis.jl
, since it was just almost working, but had a few tiny things that were different, or simply methods that were restricted to::Axis