New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech/3713/view encapsulation slider #3714

Merged

LisaWalter90 merged 4 commits into main from tech/3713/view-encapsulation-slider

Sep 4, 2024

Collaborator

polina-schoenfeld-mw commented Sep 4, 2024 •

edited

Loading

Enable ViewEncapsulation in the Slider Component

Issue: #3713

Description

Descriptive pull request text, answering:

Enabled view encapsulation for sliders

Definition of Done

A PR is only ready for merge once all the following acceptance criteria are fulfilled:

Changes have been manually tested
All TODOs related to this PR have been closed
There are automated tests for newly written code and bug fixes
All bugs discovered while working on this PR have been submitted as issues (if not already an open issue)
Documentation (GH-pages, analysis/visualization READMEs, parser READMEs, --help, etc.) has been updated (almost always necessary except for bug fixes)
CHANGELOG.md has been updated

Screenshots or gifs

polina-schoenfeld-mw added 4 commits

September 4, 2024 16:28


          chore(visualization): remove unnecessary code

ed0c5c2


          chore(visualization): style improvements

ab6ca0e


          feat(visualization): enable ViewEncapsulation and style improvements

200679f


          chore(visualization): update changelog

b784678

LisaWalter90 approved these changes

View reviewed changes

sonarcloud bot commented Sep 4, 2024

Quality Gate passed for 'CodeCharta Visualization'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud bot commented Sep 4, 2024

Quality Gate passed for 'CodeCharta Analysis'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

LisaWalter90 merged commit fed2e36 into main

7 checks passed

LisaWalter90 deleted the tech/3713/view-encapsulation-slider branch

September 4, 2024 14:52

phanlezz mentioned this pull request

View encapsulation causing component style problems in Slider Component #3713

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet