Added support for MacOS with AppKit #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ready to review when you are done |
|
Thanks. It is my first swift work so if you find something bad I am here :) |
mattiascibien
commented
Oct 29, 2024
| @@ -6,7 +6,7 @@ | |||
| // Copyright © 2017 Reed Carson. All rights reserved. | |||
| // | |||
|
|
|||
| #import <UIKit/UIKit.h> | |||
| #import <Foundation/Foundation.h> | |||
There was a problem hiding this comment.
Removed as UIKit is not cross platform and FOUNDATION_EXPORT is defined here
mattiascibien
force-pushed
the
feature/macos
branch
2 times, most recently
from
1d9aee2
to
d735db0
Compare
mattiascibien
force-pushed
the
feature/macos
branch
from
d735db0
to
67ad6e4
Compare
|
@rpcarson ready for review. I have added some changes for newer swift versions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
When trying to add the package to a multiplatform or MacOS project it is not possibile to compile as it requires
UIKit. This PR adds new handlers for handling code on MacOS withAppKitBreaking Changes
Package does not support iOS 9 anymore but in any case the project only works with iOS 15+ so it should be more correct like this
Checklist
open,public, andinternalscoped methods and properties.