Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add card types to the foreign attributes #31

Open
aleohnesTUBS opened this issue Apr 12, 2019 · 3 comments
Open

Add card types to the foreign attributes #31

aleohnesTUBS opened this issue Apr 12, 2019 · 3 comments

Comments

@aleohnesTUBS
Copy link

It would be great to have the name of the types for foreign languages.

This includes:

supertype
type
subtype
types

Thanks in advance :)

@thechucklingatom thechucklingatom added the blocked Blocked by external dependencies. label Apr 15, 2019
@thechucklingatom
Copy link
Collaborator

I will look into this a bit more, but this doesn't look like it is supported by the MTGJson project, so it is unlikely that this data set exists anywhere by my current research. You can submit an enhancement request for MTGJson here. It would have to be added into the mtgio api for it to be supported in this SDK, but if the baseline data doesn't exist it probably wouldn't be supported.

@JulesGoregues
Copy link

The JSON seem to have a field named "type".

image

@thechucklingatom
Copy link
Collaborator

It does appear to now yes. I can look into adding this. I can't say for sure what it was like 5 years ago, but I can add something for what is there now

@thechucklingatom thechucklingatom added enhancement and removed blocked Blocked by external dependencies. labels Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants