Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement foreign names for sets #32

Open
aleohnesTUBS opened this issue Apr 12, 2019 · 3 comments
Open

Implement foreign names for sets #32

aleohnesTUBS opened this issue Apr 12, 2019 · 3 comments
Labels
blocked Blocked by external dependencies.

Comments

@aleohnesTUBS
Copy link

MtgSet currently does not support foreign names for the sets. This would be a nice addition.

Thank you in advance! :)
@thechucklingatom
Copy link
Collaborator

Unfortunately after doing some research it looks like set translations is not supported by the api that the sdk gets its data from. It is supported by the MTGJson project, so it should be trivial to add to the api. If you wouldn't mind submitting an issue here. Once it gets added we can link the issue and implement the required updates to support it here.

@thechucklingatom thechucklingatom added the blocked Blocked by external dependencies. label Apr 15, 2019
@ZeldaZach
Copy link

(Seems you sent them to the MTGJSON repo by mistake, but I'll make a note upstream)

@thechucklingatom
Copy link
Collaborator

Issue #31 is the issue I sent them to you for. They are also looking for foreign names for types, which I didn't see in the current documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Blocked by external dependencies.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thechucklingatom @ZeldaZach @aleohnesTUBS