Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Future exception never retrieved in create_connection #590

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix Future exception never retrieved in create_connection #590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion uvloop/loop.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1972,7 +1972,12 @@ cdef class Loop:
lai = &lai_static

if len(fs):
await aio_wait(fs)
try:
await aio_wait(fs)
except asyncio.CancelledError as exc:
for fut in fs:
fut.cancel()
raise exc from None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why dropping the original context here, instead of just raise?


if rai is NULL:
ai_remote = f1.result()
Expand Down