Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some ESLint rules + minor changes #3665

Merged
merged 4 commits into from
Dec 30, 2024
Merged

Add some ESLint rules + minor changes #3665

merged 4 commits into from
Dec 30, 2024

Conversation

KristjanESPERANTO
Copy link
Contributor

@KristjanESPERANTO KristjanESPERANTO commented Dec 30, 2024 •
edited
Loading

Main point was to enable ESLint dot-notation and no-unneeded-ternary rules for more code consistency.

I took the occasion to add two minor commits:

  • Fix a problem found by running test:spelling
  • Minor dependency update

It wouldn't be a problem if the PR didn't arrive in the next release, the changes are cosmetic.

@rejas rejas merged commit 143dfd6 into MagicMirrorOrg:develop Dec 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rejas rejas rejas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KristjanESPERANTO @rejas