Stop using PPA for Ubuntu GitHub builds #3319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was only necessary when we were using Ubuntu 20.04 and not all of the dependencies were in the official archives. This is no longer an issue in 22.04 and beyond.
|
Isn't using the ppa a good way to make sure the ppa packages are working before they break for a user? e.g. upgrading flint broke something recently and we only found out because of this line I think. If that's not a concern, then do you want to do this in #3288 to make sure it's still fine for 24.04? |
|
That PPA flint package was flawed because we didn't also have updated packages for factory, etc. Here's a list of the packages that are hosted in the PPA: https://launchpad.net/~macaulay2/+archive/ubuntu/macaulay2 Outside of Macaulay2 itself, the only packages that are hosted are dependencies that aren't available in Ubuntu 18.04 or 20.04. So we definitely don't need it for 24.04 either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was only necessary when we were using Ubuntu 20.04 and not all of the dependencies were in the official archives. This is no longer an issue in 22.04 and beyond.