Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(control-env): checkbox / formikEffect #346

Merged
merged 2 commits into from
Sep 17, 2024
Merged

feat(control-env): checkbox / formikEffect #346

merged 2 commits into from
Sep 17, 2024

Conversation

xtiannyeto
Copy link
Collaborator

  • update validation mode... don't trigger if form is not valid
  • update trigger point.. don't trigger if checkbox is checked but no value
  • test it

@xtiannyeto
feat(control-env): checkbox / formikEffect
aa02ff6 
 - update validation mode... don't trigger if form is not valid
 - update trigger point.. don't trigger if checkbox is checked but no value
 - test it
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

Coverage Report for frontend

Status Category Percentage Covered / Total
🟢 Lines 78.15% (🎯 50%) 1825 / 2335
🟢 Statements 77.97% (🎯 50%) 1898 / 2434
🟢 Functions 75.47% (🎯 50%) 477 / 632
🟢 Branches 70.52% (🎯 50%) 792 / 1123
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
frontend/src/features/pam/mission/components/elements/controls/env-control-form.tsx 73.07% 83.33% 63.63% 76.19% 46, 46-52, 65, 68, 77, 87
frontend/src/features/pam/mission/hooks/control/use-control.tsx 85.29% 80% 77.77% 89.65% 43, 54, 63-67, 65
Generated in workflow #1021

@xtiannyeto
fix(review): check import of yup
234bcd9 
 - just import number and object
@xtiannyeto xtiannyeto merged commit 6ba4d0a into main Sep 17, 2024
9 checks passed
@xtiannyeto xtiannyeto deleted the feature/335-saisie-de-control-env branch September 17, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwih lwih lwih approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xtiannyeto @lwih