Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): update Env actions and show when several themes #341

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

lwih
Copy link
Collaborator

@lwih lwih commented Sep 13, 2024

Trou dans la raquettes quand il n'y avait plusieurs themes pour une surveillance ou controle Env.
Clémence m'a passé des nouveaux designs: https://xd.adobe.com/view/e3e667d9-4092-4bd1-ad92-69aaf2c8b3b8-b6b5/

J'ai dû changer les types côté API car la solution précédente n'était pas satisfaisante pour grouper les themes et leur subthemes associés.

Copy link

github-actions bot commented Sep 13, 2024

Coverage Report for frontend

Status Category Percentage Covered / Total
🟢 Lines 77.84% (🎯 50%) 1813 / 2329
🟢 Statements 77.72% (🎯 50%) 1881 / 2420
🟢 Functions 75.2% (🎯 50%) 470 / 625
🟢 Branches 69.13% (🎯 50%) 766 / 1108
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
frontend/src/features/common/components/elements/env-action-control-plans.tsx 100% 100% 100% 100%
frontend/src/features/common/types/env-mission-types.ts 100% 100% 100% 100%
frontend/src/features/pam/mission/components/elements/actions/action-control-env.tsx 91.66% 85% 100% 91.66% 200
frontend/src/features/pam/mission/components/elements/actions/action-surveillance-env.tsx 91.66% 87.5% 100% 91.66% 83
frontend/src/features/pam/mission/components/elements/timeline/item/timeline-item-control-env.tsx 100% 100% 100% 100%
frontend/src/features/pam/mission/components/elements/timeline/item/timeline-item-surveillance.tsx 100% 100% 100% 100%
frontend/src/features/pam/mission/hooks/use-action-by-id.tsx 33.33% 0% 0% 33.33% 375-378, 380-382, 381, 384
frontend/src/features/pam/mission/hooks/use-mission-by-id.tsx 50% 100% 0% 50% 292-294, 296
frontend/src/features/pam/mission/hooks/use-mission-timeline.tsx 83.33% 50% 100% 83.33% 125
Generated in workflow #1003

@lwih lwih marked this pull request as ready for review September 16, 2024 13:00
@lwih lwih changed the title DRAFT fix(frontend): update Env actions and show when several themes fix(frontend): update Env actions and show when several themes Sep 16, 2024
@lwih lwih merged commit 18f33bf into main Sep 16, 2024
9 checks passed
@lwih lwih deleted the multiple-control-plans branch September 16, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants