Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(318) AEM item to the correct cell #319

Conversation

aleckvincent
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Sep 3, 2024

Coverage Report for frontend

Status Category Percentage Covered / Total
🟢 Lines 78.18% (🎯 50%) 1821 / 2329
🟢 Statements 77.94% (🎯 50%) 1891 / 2426
🟢 Functions 75.47% (🎯 50%) 474 / 628
🟢 Branches 70.38% (🎯 50%) 782 / 1111
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
frontend/src/features/common/components/elements/env-action-control-plans.tsx 100% 100% 100% 100%
frontend/src/features/common/components/ui/action-dropdown.tsx 83.33% 75% 83.33% 87.5% 48-49, 52
frontend/src/features/common/types/env-mission-types.ts 100% 100% 100% 100%
frontend/src/features/pam/mission/components/elements/mission-content.tsx 30.43% 11.11% 18.18% 30.43% 56, 61, 65-85, 66-85, 68-85, 70-85, 72-85, 74-85, 76-85, 78-85, 80-85, 82-85, 84, 89-95, 97-101, 104, 108, 110-116, 118-119, 122, 124-127, 129-130, 134-142, 146-153, 157-162, 165-192, 167-169, 171-173, 175-177, 179-181, 183-185, 187-189, 191, 308
frontend/src/features/pam/mission/components/elements/mission-item.tsx 81.81% 77.77% 75% 81.39% 60, 63-64, 67, 82-87, 103, 116
frontend/src/features/pam/mission/components/elements/actions/action-control-env.tsx 90% 87.5% 100% 94.44% 33, 209
frontend/src/features/pam/mission/components/elements/actions/action-surveillance-env.tsx 91.66% 87.5% 100% 91.66% 83
frontend/src/features/pam/mission/components/elements/actions/fish/fish-control-administrative-section.tsx 100% 90% 20% 100%
frontend/src/features/pam/mission/components/elements/actions/fish/fish-control-engines-section.tsx 66.66% 0% 33.33% 66.66% 20-78
frontend/src/features/pam/mission/components/elements/controls/control-administrative-form.tsx 90.9% 80% 100% 100% 65, 81
frontend/src/features/pam/mission/components/elements/controls/control-gens-de-mer-form.tsx 90.9% 80% 100% 100% 60, 76
frontend/src/features/pam/mission/components/elements/controls/control-navigation-form.tsx 90% 80% 100% 100% 41, 53
frontend/src/features/pam/mission/components/elements/controls/control-security-form.tsx 90% 80% 100% 100% 41, 53
frontend/src/features/pam/mission/components/elements/controls/env-control-form.tsx 70% 75% 57.14% 76.47% 45, 45-51, 60, 63, 72
frontend/src/features/pam/mission/components/elements/timeline/item/timeline-item-control-env.tsx 100% 100% 100% 100%
frontend/src/features/pam/mission/components/elements/timeline/item/timeline-item-control-fish.tsx 100% 100% 100% 100%
frontend/src/features/pam/mission/components/elements/timeline/item/timeline-item-status.tsx 100% 90% 100% 100%
frontend/src/features/pam/mission/components/elements/timeline/item/timeline-item-surveillance.tsx 100% 100% 100% 100%
frontend/src/features/pam/mission/components/ui/control-title-checkbox.tsx 100% 100% 100% 100%
frontend/src/features/pam/mission/hooks/use-action-by-id.tsx 33.33% 0% 0% 33.33% 375-378, 380-382, 381, 384
frontend/src/features/pam/mission/hooks/use-mission-by-id.tsx 50% 100% 0% 50% 292-294, 296
frontend/src/features/pam/mission/hooks/use-mission-timeline.tsx 83.33% 50% 100% 83.33% 125
frontend/src/features/pam/mission/hooks/control/use-control.tsx 84.37% 85.71% 77.77% 92.59% 43, 52, 62-63, 63
Generated in workflow #1019

…es-cellules' of github.com:MTES-MCT/rapportnav2 into 318-bugexport-aem---erreur-dans-lemplacement-de-certaines-cellules
@aleckvincent aleckvincent self-assigned this Sep 9, 2024

This comment was marked as resolved.

@aleckvincent aleckvincent marked this pull request as ready for review September 10, 2024 13:19
aleckvincent and others added 5 commits September 11, 2024 14:18
 - Create a common component action-dropdown with 2 menu items, main and sub
 - on click, show sub menu item
 - remove old component
 - test it

This comment was marked as resolved.

 - use FormikEffect and Formik component
 - Add timer to delay mutation
 - Test eveything
 - new arborescence and fix test
 - Create hook with common behavior of control
 - Test hook
 - Refactor control administrative to use hook
 - Refactor control gens de mer to use hook
 - Test control gens de mer
  -  block init calls
 - Just test Have been called.
 - TODO: check number of called for later
 - default behavior, if data and unitHasConfirm null then set true
 - move common check into hook
 - test it
 - on security and navigation control use hook useControl
 - on security and navigation control Refactor form with formik and FormikEffect
 - On administrative and gensDeMer, remove control already in useControl hook
 - Add tests
 - Remove _ import, just methods
 - Update algorithm of nbrHourAtSea
 - Update tests around
 - Make sure that .last() is called on a not empty collection
@aleckvincent aleckvincent merged commit 3fc756b into main Sep 17, 2024
9 checks passed
@aleckvincent aleckvincent deleted the 318-bugexport-aem---erreur-dans-lemplacement-de-certaines-cellules branch September 17, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: READY TO TEST
Development

Successfully merging this pull request may close these issues.

bug/export AEM - erreur dans l'emplacement de certaines cellules
3 participants