Tech - Nettoyage des states redux #3687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivangabriele
approved these changes
Sep 26, 2024
| Avantages : | ||
| 1. Séparation claire des responsabilités : Chaque fenêtre a son propre cycle de vie et son propre DOM, ce qui rend la gestion des deux interfaces plus propre et modulaire. | ||
| 2. Communication efficace : BroadcastChannel est conçu pour la synchronisation des états entre différentes fenêtres, ce qui permet une synchronisation rapide et efficace sans prop drilling ou complexité supplémentaire. | ||
|
|
There was a problem hiding this comment.
Suggested change
| 3. Permet de tester les interactions main <-> side window via Cypress. | |
| 4. Permet d'utiliser des urls pour ouvrir directement les entités (`*/mission/123...`). | |
| 5. Permet le passage à Next (ou équivalent SSR) en bénéficiant du SSR aussi sur la side-window. | |
| 6. Permet de visualiser la side window dans les replays Sentry (?). | |
There was a problem hiding this comment.
Bien vu, sauf pour les 1er point point : ça ne change pas les tests d'interactions avec Cypress selon moi (sauf si j'ai raté quelque chose ?)
There was a problem hiding this comment.
Ah non c'est moi qui ait sûrement mal compris, je pensais qu'on pouvait tester plusieurs tabs ouverts simultanément en utilisant Cypress.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues