Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Préavis – Afficher la liste de diffusion (unités et leurs contacts) dans les préavis et si la diffusion a réussi ou non #3669

Merged
merged 31 commits into from
Oct 1, 2024
Merged

Préavis – Afficher la liste de diffusion (unités et leurs contacts) dans les préavis et si la diffusion a réussi ou non #3669

merged 31 commits into from
Oct 1, 2024

Conversation

ivangabriele
Copy link
Member

@ivangabriele ivangabriele commented Sep 19, 2024 •
edited
Loading

Cas non gérés

  • La liste des inscrits est générée à partir de l'historique des messages envoyés, cela veut donc dire qu'elle est vide tant qu'un message n'a pas encore été envoyé.

Linked issues

Screenshots

image

  • Tests E2E (Cypress)

@VincentAntoine VincentAntoine force-pushed the ivan/add-distribution-summary-in-pno-forms branch from a2b731d to 27cb269 Compare September 26, 2024 15:15
@VincentAntoine
Copy link
Collaborator

VincentAntoine commented Sep 26, 2024 •
edited
Loading

C'est bon pour l'ajout des colonnes dans la table prior_notification_sent_messages ;)
@ivangabriele

ivangabriele and others added 22 commits September 27, 2024 17:19
@ivangabriele
Add GetPriorNotificationSentMessages use case
e42a9e0
@ivangabriele
Add unit & inte tests for pno sent messages in Backend
bee890c
@ivangabriele
Add get pno sent messages route in Backend
3e4cb6c
@ivangabriele
Add unit test for get pno sent messages route in Backend
6ba6582
@ivangabriele
Clean naming in PriorNotificationSentMessageDataOutput
72ce82b
@ivangabriele
Add get pno sent messages route in Frontend
92f99dd
@VincentAntoine @ivangabriele
Update prior_notification_sent_messages table
e576d03
@VincentAntoine @ivangabriele
Extract administration from control units api response
3eb3e75
@VincentAntoine @ivangabriele
Update ControlUnit entity
5c82ea6
@VincentAntoine @ivangabriele
Change columns names
755ff71
@VincentAntoine @ivangabriele
Record pno recipents' name and organization
998749e
@VincentAntoine @ivangabriele
Renumber migrations
5f2ea3b
@VincentAntoine @ivangabriele
Fix test
b06bce5
@ivangabriele
Add recipient name & org to pno sent messages in Backend
bb2ea40
@ivangabriele
Dry pno card body head into shared component
34233a5
@ivangabriele
Fix table height in pno list
3753c2c
@ivangabriele
Add vesselId prop to PriorNotificationDataOutput
ec815c1
@ivangabriele
Add subscribers list & send statuses in pno form
f123d57
@ivangabriele
Order sent messages batches by date desc in pno form
7742922
@ivangabriele
Fix subscriber list style in pno form
9c95ccb
@ivangabriele
Limit sent messages data fetching to collapsed state in pno form
0ee18d1
@ivangabriele
Add e2e tests for pno form sent message list
e787242
@ivangabriele ivangabriele force-pushed the ivan/add-distribution-summary-in-pno-forms branch from b4dc22b to e787242 Compare September 30, 2024 08:45
@ivangabriele ivangabriele marked this pull request as ready for review September 30, 2024 10:04
@ivangabriele ivangabriele force-pushed the ivan/add-distribution-summary-in-pno-forms branch from d4ae8c3 to 0d86c8b Compare September 30, 2024 13:00
louptheron
louptheron approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@louptheron louptheron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, quelques petits comments

frontend/src/features/PriorNotification/components/shared/CardBodyHead/utils.ts Outdated Show resolved Hide resolved
frontend/src/features/PriorNotification/components/shared/CardBodyHead/utils.ts Outdated Show resolved Hide resolved
frontend/src/features/PriorNotification/components/shared/CardBodyHead/utils.ts Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ivangabriele ivangabriele merged commit b2534d8 into master Oct 1, 2024
26 of 27 checks passed
@ivangabriele ivangabriele deleted the ivan/add-distribution-summary-in-pno-forms branch October 1, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louptheron louptheron louptheron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ivangabriele @VincentAntoine @louptheron