[Missions] Récupérer les dates d'actions des deux centres pour le calcul des zones de mission #3041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes revolve around enhancing the system's ability to calculate mission zones more accurately by incorporating environmental mission actions and updating the infrastructure to better manage and utilize mission-related data. This involves adjustments across backend entities and frontend components to ensure that the most recent action dates, whether from fishing or environmental missions, are considered in the automatic calculation of mission zones. Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 3
Configuration used: CodeRabbit UI
Files selected for processing (102)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/alerts/PendingAlert.kt (2 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/Mission.kt (2 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/MissionAndActions.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/env_mission_action/EnvMissionAction.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/env_mission_action/MissionActionType.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/ControlCheck.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/ControlOrigin.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/Controller.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/ControlsSummary.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/FleetSegment.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/FlightGoal.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/GearControl.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/GearInfraction.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/Infraction.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/InfractionCategory.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/InfractionType.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/LogbookInfraction.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/MissionAction.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/MissionActionType.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/OtherInfraction.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/SpeciesControl.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/SpeciesInfraction.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/actrep/ActivityCode.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/actrep/JointDeploymentPlan.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/actrep/species.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/reporting/Reporting.kt (2 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/repositories/InfractionRepository.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/repositories/MissionActionsRepository.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/repositories/MissionRepository.kt (2 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/infraction/GetAllInfractions.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/GetAllMissions.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/GetMission.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/AddMissionAction.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/DeleteMissionAction.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/GetActivityReports.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/GetMissionAction.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/GetMissionActionFacade.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/GetMissionActions.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/GetVesselControls.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/UpdateMissionAction.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/dtos/ActivityReport.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/dtos/ActivityReports.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/ControllersExceptionHandler.kt (2 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/bff/MissionActionsController.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/bff/MissionController.kt (3 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/input/AddMissionActionDataInput.kt (4 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/outputs/ActivityReportDataOutput.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/outputs/ActivityReportsDataOutput.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/outputs/ControlsSummaryDataOutput.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/outputs/FullMissionWithActionsDataOutput.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/outputs/GearControlDataOutput.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/outputs/InfractionDataOutput.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/outputs/MissionActionDataOutput.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/public_api/PublicMissionActionsController.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/entities/InfractionEntity.kt (2 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/entities/MissionActionEntity.kt (5 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/repositories/JpaInfractionRepository.kt (2 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/repositories/JpaMissionActionsRepository.kt (2 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/repositories/interfaces/DBMissionActionsRepository.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/monitorenv/APIMissionRepository.kt (2 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/monitorenv/input/EnvMissionActionDataResponse.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/monitorenv/input/MissionDataResponse.kt (2 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/MissionActionUTests.kt (1 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/actrep/JointDeploymentPlanUTests.kt (1 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/GetPendingAlertsUTests.kt (2 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/GetVesselReportingsUTests.kt (3 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/GetAllMissionsUTests.kt (1 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/GetMissionUTests.kt (1 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/TestUtils.kt (1 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/AddMissionActionUTests.kt (1 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/DeleteMissionActionUTests.kt (1 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/GetActivityReportsUTests.kt (2 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/GetMissionActionFacadeUTests.kt (1 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/GetVesselControlsUTests.kt (1 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/UpdateMissionActionUTests.kt (1 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/bff/MissionsControllerITests.kt (2 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/bff/PublicMissionActionsControllerITests.kt (7 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/bff/VesselControllerITests.kt (2 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/public_api/InfractionControllerITests.kt (2 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/public_api/PublicMissionActionsControllerITests.kt (2 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/repositories/JpaInfractionRepositoryITests.kt (3 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/repositories/JpaMissionActionRepositoryITests.kt (8 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/repositories/TestUtils.kt (1 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/monitorenv/APIMissionRepositoryITest.kt (2 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/monitorenv/TestUtils.kt (2 hunks)
- frontend/cypress/e2e/side_window/mission_form/main_form.spec.ts (3 hunks)
- frontend/src/domain/entities/mission/index.ts (2 hunks)
- frontend/src/features/Mission/components/MissionForm/ActionList/index.tsx (1 hunks)
- frontend/src/features/Mission/components/MissionForm/formikUsecases.ts (3 hunks)
- frontend/src/features/Mission/components/MissionForm/hooks/useGetMainFormFormikUsecases.ts (3 hunks)
- frontend/src/features/Mission/components/MissionForm/hooks/useGetMissionActionFormikUsecases.ts (3 hunks)
- frontend/src/features/Mission/components/MissionForm/utils/getMissionFormInitialValues.ts (1 hunks)
- frontend/src/features/Mission/components/MissionList/constants.ts (2 hunks)
- frontend/src/features/Mission/components/MissionList/hooks/useGetFilteredMissionsQuery.ts (4 hunks)
- frontend/src/features/Mission/components/MissionList/index.tsx (2 hunks)
- frontend/src/features/Mission/components/MissionList/utils.tsx (2 hunks)
- frontend/src/features/Mission/mission.types.ts (1 hunks)
- frontend/src/features/Mission/monitorenvMissionApi.ts (3 hunks)
- frontend/src/features/Mission/monitorfishMissionApi.ts (3 hunks)
- frontend/src/features/Mission/useCases/deleteMissionAction.ts (3 hunks)
- frontend/src/features/Mission/useCases/editMission.ts (2 hunks)
- frontend/src/features/Mission/useCases/saveMissionAndMissionActionsByDiff.ts (2 hunks)
Files skipped from review due to trivial changes (11)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/ControlOrigin.kt
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/MissionActionType.kt
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/actrep/ActivityCode.kt
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/actrep/JointDeploymentPlan.kt
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/GetAllMissions.kt
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/GetMissionActionFacade.kt
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/GetVesselControls.kt
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/dtos/ActivityReport.kt
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/dtos/ActivityReports.kt
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/GetAllMissionsUTests.kt
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/UpdateMissionActionUTests.kt
Additional comments: 134
backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/FleetSegment.kt (1)
- 1-1: The package declaration has been correctly updated to reflect the new structure. Ensure that all references to
FleetSegmentthroughout the codebase have been updated to match this new package path.Verification successful
The executed search did not find any references to the old package path for
FleetSegmentin Kotlin files, suggesting that all references have likely been updated to reflect the new package path. However, it's recommended to manually verify this across the codebase, including in non-Kotlin files or configurations that might not have been covered by the search, to ensure complete consistency.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for old package references that might have been missed. rg --type kotlin "fr.gouv.cnsp.monitorfish.domain.entities.mission_actions.FleetSegment"Length of output: 88
backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/InfractionCategory.kt (1)
- 1-1: The package declaration has been correctly updated. Ensure that all references to
InfractionCategorythroughout the codebase have been updated to match this new package path.Verification successful
The search did not find any references to the old package path for
InfractionCategoryin Kotlin files, which suggests that the package declaration change has been correctly handled in Kotlin code. However, ensure to check for references in non-Kotlin files or configurations that might not have been covered by this search.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for old package references that might have been missed. rg --type kotlin "fr.gouv.cnsp.monitorfish.domain.entities.mission_actions.InfractionCategory"Length of output: 94
backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/ControlCheck.kt (1)
- 1-1: The package declaration has been correctly updated. Ensure that all references to
ControlCheckthroughout the codebase have been updated to match this new package path.Verification successful
The search for references to the old package path of
ControlCheckdid not yield any results, indicating that all references have likely been updated to match the new package path. It's advisable to perform a final manual check for any indirect references or configurations that might not have been caught by the search.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for old package references that might have been missed. rg --type kotlin "fr.gouv.cnsp.monitorfish.domain.entities.mission_actions.ControlCheck"Length of output: 88
backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/OtherInfraction.kt (1)
- 1-1: The package declaration has been correctly updated. Ensure that all references to
OtherInfractionthroughout the codebase have been updated to match this new package path.Verification successful
The search for old package references to
OtherInfractiondid not yield any results, suggesting that the package path update has been correctly propagated throughout the codebase.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for old package references that might have been missed. rg --type kotlin "fr.gouv.cnsp.monitorfish.domain.entities.mission_actions.OtherInfraction"Length of output: 91
backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/SpeciesInfraction.kt (1)
- 1-1: The package declaration has been correctly updated. Ensure that all references to
SpeciesInfractionthroughout the codebase have been updated to match this new package path.Verification successful
The search did not find any references to the old package path for
SpeciesInfractionin Kotlin files, suggesting that direct references have been updated. It's recommended to manually verify for any indirect references or related updates that might not have been captured by this search.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for old package references that might have been missed. rg --type kotlin "fr.gouv.cnsp.monitorfish.domain.entities.mission_actions.SpeciesInfraction"Length of output: 93
backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/GearInfraction.kt (1)
- 1-1: The package declaration has been correctly updated. Ensure that all references to
GearInfractionthroughout the codebase have been updated to match this new package path.Verification successful
The search for references to
GearInfractionunder its new package path yielded results, indicating that the class is indeed used across the codebase and that references to it have been updated to reflect the new package path. This confirms that the package declaration change forGearInfraction.kthas been correctly handled, with all necessary updates made to its references throughout the codebase.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for old package references that might have been missed. rg --type kotlin "fr.gouv.cnsp.monitorfish.domain.entities.mission_actions.GearInfraction"Length of output: 90
Script:
#!/bin/bash # Search for references to GearInfraction under the new package path to verify if it's used and correctly referenced. rg --type kotlin "fr.gouv.cnsp.monitorfish.domain.entities.mission.mission_actions.GearInfraction"Length of output: 1184
backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/InfractionType.kt (1)
- 1-1: The package declaration has been correctly updated. Ensure that all references to
InfractionTypethroughout the codebase have been updated to match this new package path.Verification successful
The executed script did not find any references to the old package path of
InfractionType, suggesting that there are no lingering references to it in Kotlin files. This is a positive indication that the package path update has been correctly handled. However, ensure that all necessary updates related to the package path change have been made throughout the codebase.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for old package references that might have been missed. rg --type kotlin "fr.gouv.cnsp.monitorfish.domain.entities.mission_actions.InfractionType"Length of output: 90
backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/LogbookInfraction.kt (1)
- 1-1: The package declaration has been correctly updated. Ensure that all references to
LogbookInfractionthroughout the codebase have been updated to match this new package path.Verification successful
The search for old package references to
LogbookInfractiondid not yield any results, indicating that all references throughout the codebase have been successfully updated to match the new package path. This supports the initial approval of the package declaration update.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for old package references that might have been missed. rg --type kotlin "fr.gouv.cnsp.monitorfish.domain.entities.mission_actions.LogbookInfraction"Length of output: 93
backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/env_mission_action/MissionActionType.kt (1)
- 1-7: The
MissionActionTypeenum is well-defined and follows Kotlin best practices. The naming convention and package structure are appropriate.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/Controller.kt (1)
- 1-4: The
Controllerdata class is correctly defined. Consider adding KDoc comments to the class and its properties for better clarity and maintainability.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/FlightGoal.kt (1)
- 1-4: The
FlightGoalenum is well-defined and follows Kotlin best practices. The naming convention and package structure are appropriate.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/MissionAndActions.kt (1)
- 1-3: The update to the import statement and the definition of
MissionAndActionsare correctly implemented, reflecting the new package structure and domain model requirements.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/Infraction.kt (1)
- 1-4: The
Infractiondata class is correctly defined. Consider adding KDoc comments to the class and its properties for better clarity and maintainability.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/repositories/InfractionRepository.kt (1)
- 1-3: The update to the import statement and the definition of
InfractionRepositoryare correctly implemented, reflecting the new package structure and domain model requirements.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/SpeciesControl.kt (1)
- 1-4: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-5]
The
SpeciesControlclass is correctly defined. Consider adding KDoc comments to the class and its properties for better clarity and maintainability.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/env_mission_action/EnvMissionAction.kt (1)
- 1-10: The
EnvMissionActiondata class is well-defined and follows Kotlin best practices. The use ofZonedDateTimeandUUIDis appropriate for the domain model. The package structure is correctly aligned with the domain-driven design.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/ControlsSummary.kt (1)
- 1-1: The package declaration aligns with the intended reorganization. This change should be cross-verified with import statements in other files that use
ControlsSummaryto ensure they are updated accordingly.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/GearControl.kt (1)
- 1-1: The package declaration aligns with the intended reorganization. This change should be cross-verified with import statements in other files that use
GearControlto ensure they are updated accordingly.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/infraction/GetAllInfractions.kt (2)
- 4-4: The import statement for
Infractionhas been correctly updated to reflect its new package structure. This is a good practice to avoid naming conflicts.- 9-9: The use of the fully qualified name in the return type of the
execute()function is a good practice to ensure clarity, especially in cases where there might be naming conflicts.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/outputs/ActivityReportsDataOutput.kt (1)
- 3-3: The import statement for
ActivityReportshas been correctly updated to reflect its new package structure. This ensures that the code remains maintainable and easy to navigate.frontend/src/features/Mission/components/MissionForm/utils/getMissionFormInitialValues.ts (2)
- 1-1: The import statement has been correctly updated to use
Missioninstead ofMissionWithActions. This change aligns with the PR objectives and should be cross-verified with other parts of the frontend to ensure consistency.- 7-7: The function signature of
getMissionDraftFromMissionWithActionshas been adjusted to reflect the updated import. Ensure that all calls to this function across the frontend are updated accordingly to avoid runtime errors.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/repositories/MissionActionsRepository.kt (1)
- 3-3: The import statement for
MissionActionhas been correctly updated to reflect its new package structure. This ensures that the code remains maintainable and easy to navigate.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/outputs/InfractionDataOutput.kt (1)
- 3-3: The import statement for
Infractionhas been correctly updated to reflect its new package structure. This ensures that the code remains maintainable and easy to navigate.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/GetMissionAction.kt (2)
- 1-1: The package declaration aligns with the intended reorganization. This change should be cross-verified with import statements in other files that use
GetMissionActionto ensure they are updated accordingly.- 4-4: The import statement for
MissionActionhas been correctly updated to reflect its new package structure. This ensures that the code remains maintainable and easy to navigate.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/DeleteMissionAction.kt (1)
- 1-1: The package declaration change aligns with the PR objectives of reorganizing the package structure for better modularity.
backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/outputs/GearControlDataOutput.kt (1)
- 3-3: The update to the import path for
GearControlaligns with the PR objectives and the reorganization of the package structure.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/GetMissionActions.kt (1)
- 1-1: The package declaration change aligns with the PR objectives of reorganizing the package structure for better modularity.
backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/AddMissionAction.kt (1)
- 1-1: The package declaration change aligns with the PR objectives of reorganizing the package structure for better modularity.
backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/alerts/PendingAlert.kt (1)
- 5-5: The update to the import path for
Infractionaligns with the PR objectives and the reorganization of the package structure.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/outputs/ControlsSummaryDataOutput.kt (1)
- 3-3: The update to the import path for
ControlsSummaryaligns with the PR objectives and the reorganization of the package structure.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/repositories/MissionRepository.kt (1)
- 26-27: The addition of the
findByIdmethod to theMissionRepositoryinterface aligns with the PR objectives of enhancing repository functionalities and improving data retrieval.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/repositories/interfaces/DBMissionActionsRepository.kt (1)
- 3-3: The update to the import path for
MissionActionTypealigns with the PR objectives and the reorganization of the package structure.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/reporting/Reporting.kt (1)
- 4-4: The import statement for
Infractionhas been updated to reflect its new package location. This is a good practice for maintaining a clean and organized codebase.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/outputs/ActivityReportDataOutput.kt (1)
- 4-5: The import paths for
ActivityCodeandActivityReporthave been updated to reflect changes in the package structure. This aligns with the reorganization of the codebase for better modularity.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/UpdateMissionAction.kt (1)
- 4-4: The import statement for
MissionActionhas been updated to reflect its new location under themissionsubpackage. This change is part of the broader reorganization effort to improve code modularity and readability.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/entities/InfractionEntity.kt (1)
- 3-4: The import paths for
InfractionandInfractionCategoryhave been updated to reflect their new package structure. This is part of the reorganization to improve code modularity.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/Mission.kt (2)
- 3-3: The import for
EnvMissionActionhas been added to support the newenvActionsfield. This aligns with the PR's objective to enhance mission zone calculations.- 19-21: New fields
createdAtUtc,updatedAtUtc, andenvActionshave been introduced. These additions are crucial for supporting enhanced mission zone calculations by incorporating action dates. Ensure that these fields are properly handled in all relevant parts of the application.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/public_api/PublicMissionActionsController.kt (1)
- 3-3: The import statement for
GetMissionActionshas been updated to reflect its new package structure. This is a necessary change to maintain consistency with the reorganization of the codebase.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/GetMission.kt (2)
- 3-7: The import statements have been updated to reflect the new package structure and to include necessary entities and use cases. This is part of the effort to enhance the modularity of the codebase.
- 11-30: The
GetMissionuse case has been implemented to fetch missions and their actions. This aligns with the PR's objective to enhance mission zone calculations. Ensure that error handling and data consistency are adequately addressed throughout the use case.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/repositories/JpaInfractionRepository.kt (2)
- 3-3: The import path for
Infractionhas been updated to reflect its new location undermission.mission_actions. This change is part of the broader reorganization effort to improve code modularity.- 14-14: The methods
findAllandfindInfractionByNatinfCodecorrectly use the updatedInfractionentity path. This ensures that the repository aligns with the new package structure. Ensure that all references to these methods are updated accordingly.Also applies to: 21-21
backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/monitorenv/input/EnvMissionActionDataResponse.kt (2)
- 21-25: Consider adding error handling for the date parsing in
toEnvMissionActionmethod. IfactionStartDateTimeUtcis not in a valid format, this could lead to runtime exceptions. It might be beneficial to catch parsing errors and handle them gracefully, possibly logging the error or throwing a custom exception that provides more context.- 28-37: The implementation of
UUIDSerializeris correct and follows the standard practices for custom serializers inkotlinx.serialization. Good job on ensuring UUIDs are properly handled during serialization and deserialization.backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/DeleteMissionActionUTests.kt (1)
- 1-8: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [11-30]
The test method
execute Should delete an actionis well-structured. However, it would be beneficial to also verify that thesavemethod ofmissionActionsRepositoryis called with the correct parameters, ensuring that the action is indeed marked as deleted before being saved. This can be done by checking the properties of theMissionActionobject captured by theargumentCaptor.backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/TestUtils.kt (2)
- 11-25: The
getDummyMissionsmethod usesZonedDateTime.now()for thestartDateTimeUtcfield, which introduces non-determinism in tests. Consider using a fixed date/time or allowing it to be passed as a parameter to ensure test consistency.- 1-29: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [26-42]
The
getDummyMissionActionsmethod introduces non-determinism by using random IDs andZonedDateTime.now(). Consider using fixed values or allowing them to be passed as parameters. Additionally, simplifying the method could improve readability and maintainability.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/monitorenv/input/MissionDataResponse.kt (1)
- 52-60: The
toFullMissionmethod lacks error handling for date parsing increatedAtUtcandupdatedAtUtc. Consider adding try-catch blocks aroundZonedDateTime.parseto handle potential parsing errors gracefully. Additionally, ensure thatenvActionsis not null before attempting to map it to domain entities.backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/repositories/JpaInfractionRepositoryITests.kt (1)
- 3-3: The update to the import path for
InfractionCategoryand the adjustments in the assertions are correct and reflect the reorganization of the domain entities. These changes ensure that the tests remain aligned with the domain model.Also applies to: 23-25, 53-55
frontend/src/features/Mission/monitorfishMissionApi.ts (1)
- 37-41: The addition of the
getMissionquery and the implementation of error handling usingFrontendApiErrorare well-executed. Ensure that the integration of this query with the frontend components is thoroughly tested, especially the error handling path.Verification successful
The integration of the
getMissionquery with frontend components is successfully verified. Its usage across various parts of theMissionfeature, including hooks and components, confirms that the query is an integral part of managing mission data within the application. This thorough integration suggests that the error handling and data fetching mechanisms provided by the query are effectively utilized across the frontend.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify the integration of getMission query with frontend components rg --type ts "useGetMissionQuery"Length of output: 1170
frontend/src/features/Mission/components/MissionList/utils.tsx (1)
- 24-24: The update to the parameter type in
hasSomeOngoingActionstoMission.MissionWithActionsis appropriate and improves type safety and clarity. This change ensures consistency with the updated import statement.frontend/src/features/Mission/components/MissionForm/hooks/useGetMainFormFormikUsecases.ts (1)
- 53-63: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [18-60]
The integration of
useGetMissionQuerywithskipTokenfor conditional data fetching and the update toupdateMissionLocationto includeenvActionsdata are well-implemented. Ensure that the functionality ofupdateMissionLocation, especially with the inclusion ofenvActions, is thoroughly tested in the context of the form's behavior.Verification successful
Given the critical role of
updateMissionLocationacross various components and hooks within theMissionfeature, it's essential to ensure its robust implementation and thorough testing, especially considering its integration withuseGetMissionQueryand the handling ofskipToken. To further verify the implementation details and ensure no issues are present, inspecting theupdateMissionLocationfunction directly informikUsecases.tsis necessary.
The partial context of the
updateMissionLocationfunction informikUsecases.tsdemonstrates a careful approach to parameter validation and early returns when necessary data is not present. This aligns with best practices for ensuring that operations are only performed with complete and valid data. However, the snippet ends before detailing howenvActions,ports, and other parameters are utilized to compute and update the mission location. To fully verify the implementation's correctness and robustness, especially in relation to the initial review comment about testing the integration withenvActions, additional context is needed.
The extended context for the
updateMissionLocationfunction informikUsecases.tsprovides valuable insights into how environmental actions (envActions) and ports are utilized to determine whether the mission location should be updated. The function checks if there is a more recent environmental action (lastEnvActionDate) compared to the mission action's date (missionAction.actionDatetimeUtc). If an environmental action is newer, it decides not to update the mission location, which is a logical approach to ensure the mission location reflects the most current and relevant data.Furthermore, the function attempts to compute the next mission geometry by dispatching
getLastControlCircleGeometrywith ports and the mission action as arguments. This indicates a sophisticated logic to update the mission's geographical data based on the latest control actions and available port data.Given this detailed examination, the implementation of
updateMissionLocationappears to be well-thought-out, with careful consideration given to the use of environmental actions and port data in determining the mission location. This aligns with the initial review comment emphasizing the importance of testing the integration and functionality ofupdateMissionLocation, especially with the inclusion ofenvActions.Based on the provided context and the analysis of the
updateMissionLocationfunction's implementation, it can be concluded that the initial review comment is consistent with the codebase, and the changes made to theuseGetMainFormFormikUsecaseshook, including the integration ofuseGetMissionQuerywithskipTokenand the update toupdateMissionLocationto includeenvActionsdata, are well-implemented.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify the functionality of updateMissionLocation in the form's behavior rg --type ts "updateMissionLocation"Length of output: 2273
Script:
#!/bin/bash # Inspect the implementation of updateMissionLocation in formikUsecases.ts rg --type ts --context 10 "const updateMissionLocation =" frontend/src/features/Mission/components/MissionForm/formikUsecases.tsLength of output: 739
Script:
#!/bin/bash # Request more context around the use of envActions and ports in updateMissionLocation rg --type ts --context 20 "const updateMissionLocation =" frontend/src/features/Mission/components/MissionForm/formikUsecases.tsLength of output: 1474
backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/public_api/InfractionControllerITests.kt (2)
- 6-7: The updated import paths align with the new package structure for
InfractionandInfractionCategory. This change is consistent with the PR objectives.- 36-43: The instantiation of
Infractionobjects with the updated import paths and parameters is correctly implemented.frontend/src/features/Mission/useCases/editMission.ts (2)
- 1-2: The addition of imports for
RTK_FORCE_REFETCH_QUERY_OPTIONSandmonitorfishMissionApisupports the updated functionality to fetch mission data with forced refetch options.- 46-48: The replacement of the mission data fetching method with
monitorfishMissionApi.endpoints.getMission.initiateis correctly implemented. Ensure to verify the integration with the frontend and the behavior of the forced refetch option.backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/public_api/PublicMissionActionsControllerITests.kt (1)
- 7-9: The updated import paths for
MissionAction,MissionActionType, andGetMissionActionscorrectly reflect the new package structure and align with the PR objectives.frontend/src/features/Mission/useCases/deleteMissionAction.ts (2)
- 19-19: The inclusion of
getStatein thedeleteMissionActionthunk signature is correctly implemented and aligns with common Redux patterns for accessing the current state within thunks.- 64-72: The introduction of the
getEnvActionsfunction to fetch environment actions based on the mission ID is correctly implemented. Ensure to verify the integration with the frontend and the correct fetching and usage ofenvActions.backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/actrep/JointDeploymentPlanUTests.kt (1)
- 1-1: The updated package declaration correctly reflects the new package structure and aligns with the PR objectives.
backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/ControllersExceptionHandler.kt (2)
- 4-4: The consolidation of exception imports makes the code cleaner and more organized.
- 43-47: The introduction of the
handleIllegalArgumentExceptionmethod to handle multiple exceptions in a generic manner is correctly implemented. Ensure to verify the correct handling of all specified exceptions.frontend/src/features/Mission/useCases/saveMissionAndMissionActionsByDiff.ts (1)
- 1-5: The import of
RTK_FORCE_REFETCH_QUERY_OPTIONSand the use ofmonitorfishMissionApito fetch mission data with forced refetch options are correctly implemented.frontend/src/features/Mission/monitorenvMissionApi.ts (1)
- 7-12: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]
The removal of the
GET_MISSION_ERROR_MESSAGEconstant, thegetMissionquery, and theuseGetMissionQueryhook aligns with the PR objectives to streamline the API. Ensure to verify the removal of any dependencies on these removed entities.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/outputs/FullMissionWithActionsDataOutput.kt (2)
- 11-32: The
FullMissionWithActionsDataOutputdata class is well-defined, covering all necessary fields for representing mission data in an output format. The use of Kotlin's data class features, nullable types, and default values for optional fields is appropriate.- 33-56: The companion object's factory method
fromMissionAndActionsis correctly implemented, providing a clean separation between the domain layer and the API output layer. It ensures that all relevant fields are mapped from the domain object to the DTO.backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/GetPendingAlertsUTests.kt (2)
- 9-10: The updated import paths for
InfractionandInfractionCategoryare correct, reflecting their new locations within the project structure. This change aligns with the reorganization of the package structure for mission-related entities.- 48-51: The modified formatting of the
Infractionobject initialization improves readability by explicitly setting each property on a separate line. This change makes the test code easier to understand and maintain.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/repositories/JpaMissionActionsRepository.kt (2)
- 4-5: The updated import paths for
MissionActionandMissionActionTypeare correct, reflecting their new locations within the project structure. This change aligns with the reorganization of the package structure for mission-related entities.- 21-53: The adjustments to method return types and parameter types, using fully qualified names for
MissionAction, are correctly implemented. This ensures clarity and avoids ambiguity, aligning with the reorganization of the package structure for mission-related entities.backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/repositories/TestUtils.kt (2)
- 3-3: The updated import path for
MissionActionand its related enums and data classes is correct, reflecting their new locations within the project structure. This change aligns with the reorganization of the package structure for mission-related entities.- 7-64: The adjustments to the references within the
getDummyMissionActionfunction, using fully qualified names forMissionActionand its related enums and data classes, are correctly implemented. This ensures clarity and avoids ambiguity, aligning with the reorganization of the package structure for mission-related entities.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/bff/MissionController.kt (2)
- 67-79: The new method
getMissionControllerin theMissionControllerclass is correctly implemented, using theGetMissionuse case to retrieve a mission by its ID and return aFullMissionWithActionsDataOutput. The use ofrunBlockingto execute the coroutine-based use case synchronously and the method annotations for REST and OpenAPI documentation are appropriate and follow best practices.- 3-11: The added imports for
GetMission,FullMissionWithActionsDataOutput,PathParam, andrunBlockingin theMissionControllerclass are necessary and correctly used to support the new functionality of thegetMissionControllermethod. Each import serves a specific purpose and is appropriately utilized.backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/AddMissionActionUTests.kt (1)
- 8-9: The updated import paths for
MissionActionandMissionActionTypeare correct, reflecting their new locations within the project structure. This change aligns with the reorganization of the package structure for mission-related entities.backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/GetMissionUTests.kt (1)
- 34-91: The unit tests in
GetMissionUTests.ktare well-structured and correctly verify the functionality of theGetMissionuse case. The tests cover the expected behavior of retrieving a mission with associated actions and handling exceptions when a mission cannot be fetched, following best practices for unit testing.backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/GetVesselReportingsUTests.kt (1)
- 5-6: The updated import paths for
InfractionandInfractionCategoryare correct, reflecting their new locations within the project structure. This change aligns with the reorganization of the package structure for mission-related entities.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/MissionAction.kt (1)
- 1-1: The package name change from
fr.gouv.cnsp.monitorfish.domain.entities.mission_actionstofr.gouv.cnsp.monitorfish.domain.entities.mission.mission_actionsis noted and aligns with the PR's objective for better modularity and organization.frontend/src/features/Mission/components/MissionForm/hooks/useGetMissionActionFormikUsecases.ts (2)
- 4-4: The addition of the
useGetMissionQueryimport from@features/Mission/monitorfishMissionApiis appropriate for fetching mission data, supporting the PR's enhancements to mission zone calculations.- 95-99: The modification to include
getMissionApiQuery.data?.envActionsin theupdateMissionLocationfunction's parameters is a thoughtful addition, ensuring environmental actions are considered when updating mission locations. This aligns well with the PR's objectives.frontend/src/features/Mission/mission.types.ts (1)
- 131-133: The modification to have
MissionWithActionsextendMissiondirectly, instead ofMission.Mission, simplifies the type hierarchy and aligns with best practices for clarity and consistency in type definitions.frontend/src/features/Mission/components/MissionList/hooks/useGetFilteredMissionsQuery.ts (1)
- 1-1: The addition of the
Missionimport from@features/Mission/mission.typesand the updates to type declarations to useMission.MissionWithActionsenhance the clarity and consistency of type usage in the codebase.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/actrep/species.kt (1)
- 1-1: The package name change to
fr.gouv.cnsp.monitorfish.domain.entities.mission.mission_actions.actrepaligns with the PR's objective for better modularity and organization within the codebase.backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/bff/MissionsControllerITests.kt (1)
- 9-10: The updates to import statements for
MissionActionandGetAllMissionsreflect the new package structure and are necessary for the tests to compile and run correctly. These changes support the PR's objectives.frontend/src/features/Mission/components/MissionList/constants.ts (1)
- 42-42: The update to use
Mission.MissionWithActionsfor the type reference withinMISSION_LIST_TABLE_OPTIONSenhances consistency and clarity in type usage across the codebase.backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/GetVesselControlsUTests.kt (1)
- 1-1: The package name change to
fr.gouv.cnsp.monitorfish.domain.use_cases.mission.mission_actionsaligns with the PR's objective for better modularity and organization within the codebase.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/bff/MissionActionsController.kt (2)
- 3-4: The updated import statements correctly reflect the new package structure for mission-related entities and use cases.
- 1-7: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [3-139]
The controller's implementation and the use of updated import statements appear to be correct and follow best practices for Spring Boot applications.
backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/GetActivityReports.kt (2)
- 1-13: The updated import statements correctly reflect the new package structure for mission-related entities and use cases.
- 1-16: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-139]
The implementation of the
GetActivityReportsuse case appears to be correct and follows best practices for domain use cases in Kotlin.backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/mission_actions/MissionActionUTests.kt (2)
- 1-1: The updated package declaration correctly reflects the new package structure for mission-related entities.
- 1-4: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-67]
The unit tests for the
MissionActionentity are well-structured and correctly verify the entity's validation logic.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/monitorenv/APIMissionRepository.kt (3)
- 127-140: The implementation of the
findByIdmethod in theAPIMissionRepositoryclass is correct and follows best practices for interacting with external services in Kotlin.- 7-7: The updated import statement for
CouldNotFindExceptioncorrectly supports the newfindByIdmethod.- 123-141: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-140]
The rest of the
APIMissionRepositoryclass is well-implemented and follows best practices for repository classes in Kotlin.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/input/AddMissionActionDataInput.kt (2)
- 3-3: The updated import statement correctly reflects the new package structure for mission-related entities.
- 13-31: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [3-57]
The declarations within the
AddMissionActionDataInputdata class correctly reference entities under the new package structure and cover a comprehensive set of attributes for mission actions.backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/GetMissionActionFacadeUTests.kt (3)
- 1-1: The updated package declaration correctly reflects the new package structure for mission-related use cases.
- 7-8: The updated import statements correctly reflect the new package structure for mission-related entities.
- 1-11: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-92]
The unit tests for the
GetMissionActionFacadeuse case are well-structured and correctly verify the use case's logic for determining the facade for mission actions.backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/outputs/MissionActionDataOutput.kt (2)
- 4-4: The updated import statement correctly reflects the new package structure for mission-related entities.
- 1-7: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [4-73]
The declarations within the
MissionActionDataOutputdata class correctly cover a comprehensive set of attributes for mission actions and include a well-implemented method for converting aMissionActionentity to output data.frontend/src/features/Mission/components/MissionForm/ActionList/index.tsx (2)
- 6-6: The updated import statement for
useGetMissionQuerycorrectly reflects the change frommonitorenvMissionApitomonitorfishMissionApi, aligning with the project's naming conventions.- 3-9: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [6-92]
The implementation of the
ActionListcomponent is well-structured and follows React best practices, efficiently handling the display and interaction with mission actions.frontend/src/domain/entities/mission/index.ts (1)
- 33-36: The explicit type annotation for the
missionparameter in thegetMissionFeaturePointfunction enhances type safety and clarity. Good practice in TypeScript to ensure the expected parameter type.frontend/src/features/Mission/components/MissionForm/formikUsecases.ts (2)
- 4-4: The import of
EnvMissionActionsupports the new functionality involving environmental actions. Necessary for the updated logic inupdateMissionLocation.- 153-167: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [147-163]
The enhancements to the
updateMissionLocationfunction, including the addition of theenvActionsparameter and the logic to compare dates before updating the mission location, significantly improve the functionality. This aligns with the objective to incorporate the most recent action dates from two centers into mission zone calculations.frontend/src/features/Mission/components/MissionList/index.tsx (2)
- 20-20: Moving the import statement for
Missionto a separate line improves readability and maintainability of the import statements.- 38-38: Updating the type reference for
MissionWithActionswithin theuseTablefunction toMission.MissionWithActionsenhances consistency and clarity in type usage.backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/monitorenv/APIMissionRepositoryITest.kt (2)
- 6-6: The import of
MissionActionTypesupports the new test case for thefindByIdfunction, involving mission action types. Necessary for the test logic.- 292-320: The new test case
findById Should return a missioneffectively verifies the functionality of thefindByIdmethod in theAPIMissionRepository. It ensures that the method correctly retrieves a mission by its ID and asserts various properties of the returned mission, contributing to the robustness of the repository layer tests.backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/GetActivityReportsUTests.kt (1)
- 7-17: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-14]
The changes in the package structure for mission-related entities and actions, as indicated by the updated import statements, contribute to better modularity and clarity of the domain model. This reorganization likely makes the codebase easier to navigate and maintain.
backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/entities/MissionActionEntity.kt (3)
- 5-5: The import statement has been updated to reflect the new package structure for mission-related entities. This change is consistent with the PR objectives of reorganizing the package structure for better modularity.
- 51-51: The properties
emitsVms,emitsAis,logbookMatchesActivity,licencesMatchActivity,separateStowageOfPreservedSpecies, andvesselTargetedhave been updated to use fully qualified class names from the new package structure. This change ensures that the entity class aligns with the updated domain model.Also applies to: 54-54, 57-57, 60-60, 67-67, 111-111
- 141-144: The methods
fromMissionActionandtoMissionActionhave been updated to reflect the changes in the domain model and package structure. These methods are crucial for converting between the entity and the domain model, ensuring data consistency across different layers of the application. The changes appear to be correctly implemented, maintaining the integrity of the data transformation process.Also applies to: 200-273
backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/repositories/JpaMissionActionRepositoryITests.kt (3)
- 3-6: The import statements have been updated to reflect the new package structure for mission-related entities. This change is necessary to ensure that the tests are aligned with the updated domain model.
- 51-59: Assertions in the test methods have been updated to use fully qualified class names from the new package structure. This ensures that the tests are correctly referencing the updated domain entities and their properties. The changes are consistent with the PR objectives and contribute to maintaining the integrity of the test suite.
Also applies to: 62-64, 69-71, 80-82, 86-88, 94-96, 113-115
- 210-217: The test method
save Should update another mission action When findById is not used to find the existing entityhas been updated to use the new domain model for creating aMissionActioninstance. This change is necessary for the test to accurately reflect the updated domain entities and their relationships. The modifications appear to be correctly implemented, ensuring the test remains valid and relevant.Also applies to: 231-233, 244-244, 254-254
backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/monitorenv/TestUtils.kt (1)
- 5-44: The method
getDummyMissionhas been added to generate a JSON string representing a mission with detailed information, includingenvActions. This utility method is useful for creating mock data for testing purposes, ensuring that tests can simulate realistic scenarios with environmental actions. The JSON structure appears to be correctly formatted and includes all necessary fields to represent a mission comprehensively.backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/bff/PublicMissionActionsControllerITests.kt (6)
- 10-16: The imports have been restructured to reflect the new package structure for mission-related entities. This change is consistent with the PR objectives to enhance mission zone calculations by incorporating the most recent action dates from two centers. Ensure that all references to these entities within the test cases have been updated accordingly to prevent any import-related issues.
- 74-80: The usage of
ControlsSummaryandMissionActionfrom the new package structure in the test caseShould get all controls for a vesselis correct and aligns with the PR's objectives. This ensures that the test is using the updated domain entities for mission actions.- 114-114: The instantiation of
MissionActionwithin the test caseShould get all mission actions for a missioncorrectly utilizes the updated entity from the new package structure. This change is necessary to reflect the enhancements made to mission zone calculations.- 158-176: In the test case
Should create a mission action with a bad facade, the creation ofLogbookInfraction,FleetSegment, andGearInfractionentities using the new package structure is correctly implemented. This ensures that the test accurately reflects the changes made to the domain entities related to mission actions.- 206-206: The use of
argumentCaptorfor capturingMissionActionin the test caseShould create a mission action with a bad facadeis appropriate. It verifies that the action created matches the expected properties, including the action date time. This is crucial for ensuring that the logic for handling mission actions remains correct after the changes.- 233-257: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [220-254]
The test case
Should update a mission actioncorrectly demonstrates the update functionality using the new domain entities. The creation of aGearControlinstance and its inclusion in theAddMissionActionDataInputpayload is a good practice for testing the update logic comprehensively.frontend/cypress/e2e/side_window/mission_form/main_form.spec.ts (3)
- 43-43: The update of the endpoint path in the intercept for GET requests from
/api/v1/missions/1to/bff/v1/missions/1is correct and aligns with the PR's objectives to enhance the backend infrastructure. This change ensures that the tests are targeting the correct, updated API endpoint.- 102-102: The repetition of the endpoint path update in another test case further confirms the consistency of changes across the test suite. This consistency is crucial for ensuring that all relevant tests are aligned with the new API endpoint structure.
- 175-175: Again, the endpoint path update is correctly applied in a different test scenario. This demonstrates thoroughness in updating the test suite to reflect changes in the API endpoint paths, ensuring that the tests remain valid and effective.
backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/bff/VesselControllerITests.kt (2)
- 17-18: The import paths for
InfractionandInfractionCategoryhave been updated to reflect the new package structure. This change aligns with the PR objectives related to reorganizing the package structure for better modularity.- 552-554: The usage of
InfractionandInfractionCategorywithin the test method for vessel reporting is consistent with their intended purpose. The test correctly constructs anInfractioninstance with anatinfCodeand aninfractionCategory, which aligns with the domain logic for handling infractions in vessel reporting.
backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/reporting/Reporting.kt
Outdated
Show resolved
Hide resolved
...rc/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/entities/InfractionEntity.kt
Outdated
Show resolved
Hide resolved
...lin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/DeleteMissionAction.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (10)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/alerts/PendingAlert.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/reporting/Reporting.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/DeleteMissionAction.kt (2 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/bff/MissionActionsController.kt (1 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/GetMissionUTests.kt (1 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/bff/MissionsControllerITests.kt (3 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/bff/PublicMissionActionsControllerITests.kt (7 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/bff/Utils.kt (1 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/public_api/PublicMissionActionsControllerITests.kt (1 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/monitorenv/TestUtils.kt (2 hunks)
Files skipped from review as they are similar to previous changes (9)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/alerts/PendingAlert.kt
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/reporting/Reporting.kt
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/mission_actions/DeleteMissionAction.kt
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/bff/MissionActionsController.kt
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/GetMissionUTests.kt
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/bff/MissionsControllerITests.kt
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/bff/PublicMissionActionsControllerITests.kt
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/public_api/PublicMissionActionsControllerITests.kt
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/monitorenv/TestUtils.kt
backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/bff/Utils.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (16)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/env_mission_action/EnvMissionAction.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/env_mission_action/EnvMissionActionType.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/input/AddMissionActionDataInput.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/entities/InfractionEntity.kt (2 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/entities/MissionActionEntity.kt (3 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/repositories/JpaInfractionRepository.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/repositories/JpaMissionActionsRepository.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/monitorenv/input/EnvMissionActionDataResponse.kt (1 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/GetMissionUTests.kt (1 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/bff/PublicMissionActionsControllerITests.kt (4 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/bff/VesselControllerITests.kt (1 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/public_api/InfractionControllerITests.kt (2 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/repositories/JpaInfractionRepositoryITests.kt (3 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/repositories/JpaMissionActionRepositoryITests.kt (4 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/repositories/TestUtils.kt (1 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/monitorenv/APIMissionRepositoryITest.kt (2 hunks)
Files skipped from review as they are similar to previous changes (15)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/env_mission_action/EnvMissionAction.kt
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/input/AddMissionActionDataInput.kt
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/entities/InfractionEntity.kt
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/entities/MissionActionEntity.kt
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/repositories/JpaInfractionRepository.kt
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/repositories/JpaMissionActionsRepository.kt
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/monitorenv/input/EnvMissionActionDataResponse.kt
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/mission/GetMissionUTests.kt
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/bff/PublicMissionActionsControllerITests.kt
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/bff/VesselControllerITests.kt
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/public_api/InfractionControllerITests.kt
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/repositories/JpaInfractionRepositoryITests.kt
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/repositories/JpaMissionActionRepositoryITests.kt
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/repositories/TestUtils.kt
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/monitorenv/APIMissionRepositoryITest.kt
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (3)
- frontend/cypress/e2e/side_window/mission_form/sea_control_edition.spec.ts (2 hunks)
- frontend/src/features/Mission/components/MissionForm/MainForm/FormikLocationPicker.tsx (1 hunks)
- frontend/src/features/Mission/components/MissionForm/formikUsecases.ts (3 hunks)
Files skipped from review as they are similar to previous changes (1)
- frontend/src/features/Mission/components/MissionForm/formikUsecases.ts
Additional comments: 3
frontend/src/features/Mission/components/MissionForm/MainForm/FormikLocationPicker.tsx (1)
- 120-128: The addition of a conditional check before dispatching a notification event based on the length of
geometryComputedFromControls.coordinatesis a logical enhancement. It ensures that notifications are only dispatched when there are actual coordinates to report on, which can help in avoiding unnecessary notifications or errors in cases where the geometry is not set or is empty.However, it's important to ensure that the management and update mechanisms for
geometryComputedFromControlsare robust and align with the expected behavior throughout the application lifecycle. This includes verifying that coordinates are correctly updated or cleared as needed, to prevent stale or incorrect data from triggering misleading notifications.Verification successful
The verification process has revealed that
geometryComputedFromControlsis managed in a structured manner within the application. It is part of theMissionFormStateand is manipulated through specific actions for initializing, updating, and resetting this state. This management approach ensures thatgeometryComputedFromControlsis handled appropriately across the application lifecycle, aligning with the concerns raised in the original review comment.The addition of a conditional check before dispatching a notification event, as observed in
FormikLocationPicker.tsx, is logically sound and benefits from the robust state management practices observed. It's crucial that these practices continue to be followed to ensure the application behaves as expected, especially in relation to managing mission geometry data.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify that `geometryComputedFromControls` is managed correctly across the application # This script is a placeholder and should be adapted to the specific verification needs echo "Ensure that geometryComputedFromControls is updated and cleared appropriately in all relevant parts of the application."Length of output: 248
Script:
#!/bin/bash # Search for references to `geometryComputedFromControls` across the application to understand how it's managed and updated rg "geometryComputedFromControls" --context 5Length of output: 11990
frontend/cypress/e2e/side_window/mission_form/sea_control_edition.spec.ts (2)
- 2-2: The addition of the import statement for
SeaFrontGroupfromsrc/domain/entities/seaFront/constantsis correctly implemented and necessary for the new test case that checks the mission zone update logic under specific conditions.- 269-295: The new test case "Should not update the mission zone When a CACEM control is newer" is well-structured and effectively simulates the scenario where a newer CACEM control should not trigger an update to the mission zone. This is crucial for ensuring the application behaves as expected in scenarios where control data might come in asynchronously or out of order.
It's recommended to verify the integration with the backend and ensure that the logic for determining the "newness" of a control and its impact on mission zone updates is correctly implemented and tested across various edge cases.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (6)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/env_mission_action/EnvMissionAction.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/monitorenv/input/EnvMissionActionDataResponse.kt (1 hunks)
- frontend/cypress/e2e/side_window/mission_form/main_form.spec.ts (4 hunks)
- frontend/src/features/Mission/components/MissionForm/ActionList/index.tsx (2 hunks)
- frontend/src/features/Mission/components/MissionForm/formikUsecases.ts (3 hunks)
- frontend/src/features/Mission/envMissionAction.types.ts (2 hunks)
Files skipped from review as they are similar to previous changes (5)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/entities/mission/env_mission_action/EnvMissionAction.kt
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/monitorenv/input/EnvMissionActionDataResponse.kt
- frontend/cypress/e2e/side_window/mission_form/main_form.spec.ts
- frontend/src/features/Mission/components/MissionForm/ActionList/index.tsx
- frontend/src/features/Mission/components/MissionForm/formikUsecases.ts
Additional comments: 1
frontend/src/features/Mission/envMissionAction.types.ts (1)
- 5-5: The change to make
actionStartDateTimeUtcoptional in theMissionActioninterface could have significant implications on how instances ofMissionActionare created and used. Ensure that all usages ofMissionActionthroughout the application are reviewed to handle the potential absence ofactionStartDateTimeUtccorrectly.
louptheron
commented
Mar 27, 2024
...nd/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/infraction/GetAllInfractions.kt
Outdated
Show resolved
Hide resolved
louptheron
commented
Mar 27, 2024
...main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/entities/MissionActionEntity.kt
Outdated
Show resolved
Hide resolved
louptheron
commented
Mar 27, 2024
...tlin/fr/gouv/cnsp/monitorfish/infrastructure/api/bff/PublicMissionActionsControllerITests.kt
Outdated
Show resolved
Hide resolved
claire2212
approved these changes
Mar 27, 2024
|
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (3)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/infraction/GetAllInfractions.kt (1 hunks)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/entities/MissionActionEntity.kt (3 hunks)
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/bff/PublicMissionActionsControllerITests.kt (3 hunks)
Files skipped from review as they are similar to previous changes (3)
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/domain/use_cases/infraction/GetAllInfractions.kt
- backend/src/main/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/database/entities/MissionActionEntity.kt
- backend/src/test/kotlin/fr/gouv/cnsp/monitorfish/infrastructure/api/bff/PublicMissionActionsControllerITests.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues
Summary by CodeRabbit