Skip to content

Commit

Permalink
Ensure artifact download comes from the same commit sha in applicatio…
Browse files Browse the repository at this point in the history
…n workflows
  • Loading branch information
ivangabriele committed Feb 28, 2024
1 parent 6809459 commit 28d79cb
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/application_deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ jobs:
- name: Download image
uses: ishworkh/[email protected]
with:
commit_sha: ${{ github.event.workflow_run.head_commit.id }}
image: monitorfish-app:${{ env.VERSION }}
token: ${{ secrets.GITHUB_TOKEN }}
workflow: "Application Build"
Expand All @@ -53,6 +54,6 @@ jobs:
- uses: LouisBrunner/[email protected]
if: ${{ always() }}
with:
token: ${{ secrets.GITHUB_TOKEN }}
name: Application Deployment
conclusion: ${{ job.status }}
name: Application Deployment
token: ${{ secrets.GITHUB_TOKEN }}
10 changes: 6 additions & 4 deletions .github/workflows/application_e2e_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ jobs:
- name: Download image
uses: ishworkh/[email protected]
with:
commit_sha: ${{ github.event.workflow_run.head_commit.id }}
image: monitorfish-app:${{ env.VERSION }}
token: ${{ secrets.GITHUB_TOKEN }}
workflow: "Application Build"
Expand Down Expand Up @@ -89,9 +90,9 @@ jobs:
- uses: LouisBrunner/[email protected]
if: ${{ always() }}
with:
token: ${{ secrets.GITHUB_TOKEN }}
name: Application Cypress E2E tests
conclusion: ${{ job.status }}
name: Application Cypress E2E tests
token: ${{ secrets.GITHUB_TOKEN }}

e2e_multi_windows_test:
name: Run E2E multi windows tests
Expand All @@ -115,6 +116,7 @@ jobs:
- name: Download image
uses: ishworkh/[email protected]
with:
commit_sha: ${{ github.event.workflow_run.head_commit.id }}
image: monitorfish-app:${{ env.VERSION }}
token: ${{ secrets.GITHUB_TOKEN }}
workflow: "Application Build"
Expand Down Expand Up @@ -147,6 +149,6 @@ jobs:
- uses: LouisBrunner/[email protected]
if: ${{ always() }}
with:
token: ${{ secrets.GITHUB_TOKEN }}
name: Application Puppeteer E2E tests
conclusion: ${{ job.status }}
name: Application Puppeteer E2E tests
token: ${{ secrets.GITHUB_TOKEN }}

0 comments on commit 28d79cb

Please sign in to comment.