Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint(eslint): enforce nullish coalescing #987

Merged
merged 2 commits into from
Jan 17, 2024
Merged

lint(eslint): enforce nullish coalescing #987

merged 2 commits into from
Jan 17, 2024

Conversation

ivangabriele
Copy link
Member

@ivangabriele ivangabriele commented Jan 17, 2024 •
edited
Loading

  • Je n'ai réservé le nullish coalescing operator que pour les cas de valeurs par défaut qui ne soient pas booléennes.
  • Pour les booléens j'ai préféré,m'assurer de caster toutes les valeurs des if via !!.

Related Pull Requests & Issues

None

Preview URL

https://637e01cf5934a2ae881ccc9d-ccjnoxhquj.chromatic.com/

@ivangabriele ivangabriele force-pushed the ivan/lint-eslint-enforce-nullish-coalescing branch from c2002da to a28449c Compare January 17, 2024 09:13
@ivangabriele ivangabriele merged commit 0323919 into main Jan 17, 2024
12 checks passed
@ivangabriele ivangabriele deleted the ivan/lint-eslint-enforce-nullish-coalescing branch January 17, 2024 09:37
@ivangabriele
Copy link
Member Author

🎉 This PR is included in version 11.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claire2212 claire2212 claire2212 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivangabriele @claire2212