-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Bloquer la saisie des caractères non numérique sur les NumberInput #1240
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1240 +/- ##
=======================================
Coverage 57.39% 57.39%
=======================================
Files 55 55
Lines 805 805
Branches 267 274 +7
=======================================
Hits 462 462
+ Misses 343 327 -16
- Partials 0 16 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
8b72e1c
to
c47a827
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On ne peut pas entrer de nombre flottant. Peut-être que decimal
le permet je n'ai pas vérifié.
@@ -119,11 +96,11 @@ export function NumberInput({ | |||
$isTransparent={isTransparent} | |||
disabled={disabled} | |||
id={name} | |||
onBlur={handleBlur} | |||
inputMode="numeric" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inputMode="numeric" | |
inputMode="decimal" |
108174d
to
cacaff8
Compare
@maximeperraultdev Une fois que tu auras rebased tu auras de nouveau une erreur de commitlint parce que j'ai enforced les scopes sur les feat/fix/style pour conserver des release notes cleans. C'est assez logique normalement car ça suit tout simplement le nom des dossiers => C'est le style que je tente de faire suivre, un verbe + le nom du/des composants concernés. |
cacaff8
to
0b1df21
Compare
Quality Gate passedIssues Measures |
Preview URL
https://637e01cf5934a2ae881ccc9d-vqhlatcibl.chromatic.com/