Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/business types in controls #469

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Feat/business types in controls #469

merged 6 commits into from
Dec 10, 2024

Conversation

tristan-gueguen
Copy link
Contributor

sandrica89
sandrica89 reviewed Dec 9, 2024
View reviewed changes
Copy link
Contributor

@sandrica89 sandrica89 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may also add some data in the current seed (of the breach rules scenario for example) to be able to test this case easily. => already done ✔️

app/tests/controls/test_business_type_in_control.py Outdated Show resolved Hide resolved
app/data_access/control_data.py Outdated Show resolved Hide resolved
@tristan-gueguen tristan-gueguen merged commit 136022b into master Dec 10, 2024
2 of 4 checks passed
@tristan-gueguen tristan-gueguen deleted the feat/business-types-in-controls branch December 10, 2024 16:05
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 10, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandrica89 sandrica89 sandrica89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tristan-gueguen @sandrica89