Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BO - Tableaux] Template Twig pour les tableaux du BO #3405

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

emilschn
Copy link
Collaborator

@emilschn emilschn commented Dec 6, 2024

Ticket

#3377

Description

Création d'un fichier twig à inclure en BO lorsqu'on crée un tableau.
Premier pas vers une standardisation.

Changements apportés

  • J'en ai profité pour retoucher quelques titres / descriptions de tableaux... C'était secondaire mais bon...

Tests

@emilschn emilschn force-pushed the feature/3377-table-twig-include branch from 9449c6a to e5e5e1a Compare December 9, 2024 08:36
Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quelques soucis de tabulations (enfin ce que je vois dans le diff de github).

Il manque la liste des utilisateurs du partenaire je pense
Eventuellement la liste des colonnes à ajouter à l'export, mais ça veut dire ajouter une option "selectable"

templates/back/expired-account/index.html.twig Outdated Show resolved Hide resolved
@hmeneuvrier
Copy link
Collaborator

Tu peux passer en faux positif l'alerte sonar sur l'absence de dans templates/_partials/back/table.html.twig

@emilschn emilschn force-pushed the feature/3377-table-twig-include branch from de7e1b7 to 10a4703 Compare December 9, 2024 10:56
Copy link
Collaborator

@hmeneuvrier hmeneuvrier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK c'est bon pour moi, tests et lecture

@emilschn emilschn force-pushed the feature/3377-table-twig-include branch from 68fc9f0 to e3f902b Compare December 10, 2024 08:30
Copy link

sonarcloud bot commented Dec 10, 2024

Copy link
Collaborator

@numew numew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@numew numew merged commit 65086f1 into develop Dec 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants