Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API Histologe] Avancer sur une route GET #3339

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

[API Histologe] Avancer sur une route GET #3339

wants to merge 4 commits into from

Conversation

numew
Copy link
Collaborator

@numew numew commented Nov 26, 2024 •
edited
Loading

Ticket

#3307

Description

Créations de 2 routes sur l'API permettant de récupérer

  • Une liste des {limit} derniers signalement affecter a son partenaire (à venir : ses partenaires)
  • Un signalement via son uuid (à condition qu'il soit affecté à l'user)

Tests

Préparation

  • Se rendre sur http://localhost:8080/api/doc, télécharger le fichier openapi.json de spécification de l'API et l'importer dans postman.
  • Définir la valeur de la variable d'env baseUrl et bearerToken et sauvegarder
    Capture d’écran 2024-11-29 150920
  • Copier ce script dans l'onglet Test de la route login et sauvegarder
    Capture d’écran 2024-11-29 150944
var data = JSON.parse(responseBody);

if (data.data !== null) {
    pm.collectionVariables.set("bearerToken", data.token);
}
  • S’authentifier avec un des user de test ayant le ROLE_API_USER
    Capture d’écran 2024-11-29 162301
{
"email": "[email protected]",
"password": "histologe"
}
  • Tester les 2 routes de récupération de signalements

@numew numew force-pushed the feature/3307-histologe-api-get branch 3 times, most recently from 4a80e75 to b2c3125 Compare November 29, 2024 15:05
@numew numew marked this pull request as ready for review November 29, 2024 15:24
@numew numew changed the title [WIP] [API Histologe] Avancer sur une route GET [API Histologe] Avancer sur une route GET Nov 29, 2024
emilschn
emilschn reviewed Dec 2, 2024
View reviewed changes
src/Controller/Api/SignalementController.php Outdated
UrlGeneratorInterface $urlGenerator,
string $reference,
): JsonResponse {
$signalements = $signalementRepository->findForAPI(user : $this->getUser(), reference : $reference);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ça va pas poser souci pour les utilisateurs en multi-territoire ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oui j'ai mis un todo dans la requête j'adapterais après le merge de la PR multi ter.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrigé

emilschn
emilschn reviewed Dec 2, 2024
View reviewed changes
src/Dto/Api/Response/SuiviResponse.php Outdated
$this->description = $suivi->getDescription(); // traitement de suppression du html ? comment gérer les bouton/doc qui sont présent en dur dans le contenu ?
$this->public = $suivi->getIsPublic();
$this->type = $suivi->getType(); // envoyer un libellé ?
// exposer "createdBy" sous quelle forme ?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ça semble important ; au même format que sur la fiche signalement ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mouais, je suis pas convaincu par l'usine a gaz qui c'est monté au fil du temps sur ce point la coté fiche signalement. J'ai mis un TODO pour réfléchir au sujet mais aprés le merge multi territoire qui impacte le sujet.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est fait

sfinx13
sfinx13 reviewed Dec 2, 2024
View reviewed changes
src/Controller/Api/SignalementController.php Show resolved Hide resolved
src/Controller/Api/SignalementController.php Show resolved Hide resolved
src/Controller/Api/SignalementController.php
#[When('dev')]
#[When('test')]
#[Route('/api')]
class SignalementController extends AbstractController
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On part du principe que les signalements sont récupérable à partir du moment ou la DDT valide et affecte au partenaire. Si le partenaire à une clé d'API elle peut récupérer les signalements affectés à un ou plusieurs type de partenaires.

Permettre le filtre par date et plage de date, ça serait la date d'affectation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai effectivement revu le principe pour retourner la liste des signalements affectés au partenaire de l'user API.
Pour les filtres (dates ou autres) est-ce qu'on attends pas un autre ticket ? Il faudrait dans ce cas rajouter la date d'affectation pour le partenaire dans ce qui est retourné.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour l'ajout de filtres, on peut attendre un autre ticket

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3424

src/Controller/Api/SignalementController.php Outdated Show resolved Hide resolved
src/Controller/Api/SignalementController.php Outdated Show resolved Hide resolved
src/Dto/Api/Response/SignalementResponse.php
Comment on lines +62 to +69
public ?string $civiliteOccupant;
public ?string $nomOccupant;
public ?string $prenomOccupant;
public ?string $telephoneOccupant;
public ?string $telephoneSecondaireOccupant;
public ?string $mailOccupant;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

élément d'objet personne

src/Dto/Api/Response/SignalementResponse.php
Comment on lines +87 to +102
public ?string $typeProprietaire;
public ?string $nomProprietaire;
public ?string $prenomProprietaire;
public ?string $adresseProprietaire;
public ?string $codePostalProprietaire;
public ?string $villeProprietaire;
public ?string $telephoneProprietaire;
public ?string $telephoneSecondaireProprietaire;
public ?string $mailProprietaire;
public ?string $proprietaireRevenuFiscal;
public ?bool $proprietaireBeneficiaireRsa;
public ?bool $proprietaireBeneficiaireFsl;
public ?string $proprietaireDateNaissance;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Élément d'objet personne

src/Dto/Api/Response/SignalementResponse.php Outdated Show resolved Hide resolved
src/Dto/Api/Response/SignalementResponse.php Outdated Show resolved Hide resolved
src/Dto/Api/Response/SuiviResponse.php Outdated Show resolved Hide resolved
@numew numew force-pushed the feature/3307-histologe-api-get branch 3 times, most recently from b90d14a to 7450061 Compare December 9, 2024 15:36
@numew numew mentioned this pull request Dec 10, 2024
Open
@sfinx13 sfinx13 mentioned this pull request Dec 10, 2024
Open
@numew numew force-pushed the feature/3307-histologe-api-get branch from c9be2fe to 542325a Compare December 10, 2024 16:28
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 10, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sfinx13
sfinx13 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@sfinx13 sfinx13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lecture et test OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilschn emilschn emilschn left review comments

@sfinx13 sfinx13 sfinx13 approved these changes

@hmeneuvrier hmeneuvrier Awaiting requested review from hmeneuvrier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@numew @emilschn @sfinx13