Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.13: Python 3.13 compatibility and minor updates #346

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

MSeifert04
Copy link
Owner

unfortunately this means the code needs to revert to the (slower)
PyArg_ParseTuple

CI:

  • Update pypy build
  • Update python 3.12 build
  • Add python 3.13 rc2 build

@MSeifert04
Copy link
Owner Author

MSeifert04 commented Sep 24, 2024

removal of _PyArg_ParseStack python/cpython#110964

removal of _PyDict_SetItem_KnownHash python/cpython#108449 (the get-item variant was restored later in python/cpython#112115)

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.35%. Comparing base (d3df1a7) to head (fb458c1).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #346   +/-   ##
=======================================
  Coverage   96.35%   96.35%           
=======================================
  Files          55       55           
  Lines        4281     4283    +2     
  Branches       98       98           
=======================================
+ Hits         4125     4127    +2     
  Misses        155      155           
  Partials        1        1           
Flag Coverage Δ
unittests 96.35% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MSeifert04 MSeifert04 force-pushed the python-3.13-removed-pyarg-parsestack branch from 48ee539 to 415bdf2 Compare September 24, 2024 16:49
@MSeifert04 MSeifert04 force-pushed the python-3.13-removed-pyarg-parsestack branch from 7453db9 to 71e034d Compare September 24, 2024 17:12
@MSeifert04 MSeifert04 force-pushed the python-3.13-removed-pyarg-parsestack branch 2 times, most recently from e437e1d to c7998ba Compare October 7, 2024 22:57
Python 3.13 removed _PyArg_ParseStack and _PyDict_SetItem_KnownHash from the C API

Unfortunately this means that the code has to resort to the old (not as optimized)
approaches again.

CI:
- Update pypy build
- Update python 3.12 build
- Add python 3.13 rc2 build
- update cibuildwheel
- fix mistake in url for pypy build
- fix missing artifacts for benchmarks

Misc:

- Fix numpydoc warnings
- Increase Python version that's linked in the docs
@MSeifert04 MSeifert04 force-pushed the python-3.13-removed-pyarg-parsestack branch from c7998ba to fb458c1 Compare October 8, 2024 00:01
@MSeifert04 MSeifert04 changed the title Maintenance: Python 3.13 removed _PyArg_ParseStack from the C API Version 0.13: Python 3.13 compatibility and minor updates Oct 8, 2024
@MSeifert04 MSeifert04 merged commit 085e3c6 into master Oct 8, 2024
18 checks passed
@MSeifert04 MSeifert04 deleted the python-3.13-removed-pyarg-parsestack branch October 8, 2024 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant