This repository has been archived by the owner on Oct 23, 2020. It is now read-only.
Bug fix to MPAS forcing #1227
Open
Bug fix to MPAS forcing #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug fix to correct the alarms when the forcing clock is cycled.
|
I intended this PR as a beginning of a discussion about how to solve this issue. |
|
@akturner we have not looked at this for a long time. Is this ready to be tested and merged, or is the situation changed by all the other forcing requests to framework? How should it be tested, to show that it fixes a problem? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix to correct the alarms when the forcing clock is cycled.
The forcing clock time is manually set back by the forcing cycle duration. The call to calibrate alarms in mpas_set_clock_time does not set the forcing clock alarms back correctly (I'm not sure you would expect it to). This solution the alarm time is also manually set back by the forcing alarm duration. This has been tested in the sea ice model and seems to give correct answers, but I'm not sure this is the correct solution.