Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wave Mesh Tools #579

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

erinethomas
Copy link

This PR adds all the tools required for creating WAVEWATCHIII meshes

@erinethomas erinethomas requested review from sbrus89 and xylar September 5, 2024 18:02
@xylar
Copy link
Collaborator

xylar commented Sep 5, 2024

Impressive work, @erinethomas and @sbrus89! For now, my suggestion would be to add a few tests to:
https://github.com/MPAS-Dev/MPAS-Tools/blob/master/conda_package/recipe/meta.yaml#L98
These can be as simple as making sure the executables are there (like the first 3) or even better running them to get a help message if that's possible.

@erinethomas
Copy link
Author

good suggestion - ill try to get those done before the end of the week

@xylar
Copy link
Collaborator

xylar commented Sep 5, 2024

I was able to build the conda package on Chrysalis so this looks great to me from a technical perspective. Let me know if you want me to test actually running any of these tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants