Enable GPU execution of atm_compute_moist_coefficients via OpenACC #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abishekg7
changed the title
gdicker1
reviewed
Jan 2, 2025
|
|
||
|
|
||
| !$acc parallel | ||
| !$acc loop |
There was a problem hiding this comment.
I think the loop directives should be more explicit (e.g. loop gang worker here). Just to match with other work we're doing.
gdicker1
reviewed
Jan 2, 2025
| do iq = moist_start, moist_end | ||
| qtotal = qtotal + 0.5 * ( scalars(iq, k, cell1) + scalars(iq, k, cell2) ) | ||
| end do | ||
| cqu(k,iEdge) = 1.0 / (1.0 + qtotal) | ||
| end do | ||
| end if | ||
| end do | ||
| !$acc end parallel | ||
| !$acc exit data copyout(cqw, cqu, qtot) delete(scalars) |
There was a problem hiding this comment.
This exit data directive should be surrounded by MPAS_ACC_TIMER_{START,STOP} calls.
gdicker1
suggested changes
Jan 2, 2025
There was a problem hiding this comment.
This may need some additional work. When I compared baseline and test runs of the regional testcase, I get differences in two fields in the history file. Restart files are reported as matching.
Output from compare_netcdf.py:
Comparing files: f1 - f2
f1=../2024Dec31_MPASAPR1223_OpenACC/baseline_acc_1735844488/history.2019-09-01_00.06.00.nc
f2=test_att1735694999/history.2019-09-01_00.06.00.nc
Variable Min Max
=========================================
initial_time is not a numeric field and will not be compared
xtime is not a numeric field and will not be compared
depv_dt_fric -32.448421 33.315609
depv_dt_fric_pv -32.448421 30.517973
mminlu is not a numeric field and will not be compared
Also a couple of suggested edits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the GPU execution of atm_compute_moist_coefficients subroutine.
Tested with a real and idealized test cases.