Enable PIO to Add Attributes to Existing NetCDF Files #1234
Conversation
amstokely
force-pushed
the
framework/pio_put_att
branch
from
228b58c to
7b75c62
Compare
|
@amstokely Can you fix up the commit history? As of now it looks like there are 23 files changed. |
- Adds support for adding new attributes to existing NetCDF files by minimizing expensive mode switches between data and define modes. - Introduces `put_att_pio` interface with try-fail logic, handling scalar and 1D attributes of various data types (int, real, double, string). - Enhances performance by avoiding unnecessary transitions and includes extensive logging for better traceability. - Ensures backward compatibility for NetCDF files generated by earlier MPAS versions.
amstokely
force-pushed
the
framework/pio_put_att
branch
from
7b75c62 to
c066590
Compare
@mgduda I just rebased off of the current MPAS-Dev develop branch. This should resolve the previously large diff. |
| if (handle_put_att_pio_enddef(handle) /= PIO_noerr) return | ||
| if (present(ierr)) ierr = MPAS_IO_NOERR | ||
| end if | ||
| return |
There was a problem hiding this comment.
We could remove this return statement.
| @@ -5919,20 +6074,20 @@ subroutine MPAS_io_put_att_real1d(handle, attName, attValue, fieldname, syncVal, | |||
| allocate(singleVal(size(attValueLocal))) | |||
| singleVal(:) = real(attValueLocal(:),R4KIND) | |||
| #ifdef MPAS_PIO_SUPPORT | |||
| pio_ierr = PIO_put_att(handle % pio_file, varid, attName, singleVal) | |||
| pio_ierr = put_att_pio(handle, varid, attName, singleVal, ierr=ierr) | |||
There was a problem hiding this comment.
I think there may be another space of indentation that's needed here to align with other code.
| @@ -5950,6 +6105,9 @@ subroutine MPAS_io_put_att_real1d(handle, attName, attValue, fieldname, syncVal, | |||
| end subroutine MPAS_io_put_att_real1d | |||
|
|
|||
|
|
|||
|
|
|||
|
|
|||
|
|
|||
There was a problem hiding this comment.
It would be preferable to not add these three blank lines.
| @@ -5033,6 +5037,149 @@ subroutine MPAS_io_get_att_real1d(handle, attName, attValue, fieldname, precisio | |||
|
|
|||
| end subroutine MPAS_io_get_att_real1d | |||
|
|
|||
| function handle_put_att_pio_redef(handle) result (pio_ierr) | |||
There was a problem hiding this comment.
Why is _put_att_ in these function names? They don't do anything with attributes.
|
@amstokely I've un-resolved several comments that were marked as resolved but didn't appear to actually have been addressed. Can you take another look at these? |
Add Ability to Write New Attributes to Existing NetCDF Files in PIO
Overview:
Currently, PIO in MPAS lacks the ability to add new attributes to existing NetCDF files. This limitation arises because when PIO attempts to write a new attribute, the file remains in data mode, which does not allow for the addition of attributes. Instead, attributes can only be added when the file is in define mode.
Unfortunately, the public APIs of both PIO and NetCDF do not provide a way to inquire about a file’s current mode. Switching to define mode each time a new attribute is needed is expensive, as transitioning between data and define modes introduces significant I/O costs.